Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected error when tried to load a *.bat file in a private repository. #93

Closed
vilemj-Viclick opened this issue Feb 15, 2019 · 6 comments
Labels
good first issue Good for newcomers

Comments

@vilemj-Viclick
Copy link

This is what I got, when I tried on a random file in a private repo in our organization (github entity).
image
I mean I didn't expect it to work, but it says to report the issue, so here I am.

I tried a different file in the same repository, and now it says this:
image

This leads me to being a bit more specific. The exact URL i tried is:
https://github.githistory.xyz/KenticoInternal/draft-client/blob/master/autostart.bat

To be clear, there is 'some' history with this file:
image

@pomber
Copy link
Owner

pomber commented Feb 15, 2019

Thanks. Do you want to try to fix it? Here's a PR solving it for other file extensions: #82

@pomber pomber added the good first issue Good for newcomers label Feb 16, 2019
@theNaut1lus
Copy link

Would love to work on this if no one else is. @pomber @vilemj-Viclick

@pomber
Copy link
Owner

pomber commented Feb 16, 2019

All yours. Let me know if you need help

@theNaut1lus
Copy link

Roger that. @pomber let me give this a try and get back at you 👍

@theNaut1lus
Copy link

@pomber

Going through the issue, code base and the link provided i have observed that there is present a test and a regex for the .bat file extension.
Which makes me think that this is not an issue related to the PR you have linked.
Is there any general direction in which you would like to point me towards if you have a fix in mind.
Thanks a lot in advance.

@pomber
Copy link
Owner

pomber commented Feb 16, 2019

The language returned should match one of the languages from prism: https://github.com/PrismJS/prism/tree/master/components. ("batch" maybe?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants