Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable templating / default annotations for Ingress to Route mapping #486

Open
EBNull opened this issue Jan 15, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@EBNull
Copy link

EBNull commented Jan 15, 2023

Is your feature request related to a problem? Please describe.

I would like to apply the ingress.pomerium.io/preserve_host_header annotation to all Ingress objects by default to make Pomerium act more consistently like other proxies instead of editing every Ingress object in the cluster.

Describe the solution you'd like

I would like the Pomerium CRD to grow a spec for DefaultIngressAnnotations which would serve as default annotation values. This could be added just after

Describe alternatives you've considered

  • Editing every Ingress object in the cluster.
  • Forking the ingress controller and adding
    tmpl.PreserveHostHeader = true
    outside the if statement.
  • Sticking with Traefik and somehow using Pomerium as a ForwardAuth entry for authn and authz

Explain any additional use-cases

Other configuration would be handled in the same manner.

Additional context

I'm evaluating switching from Traefik + Custom ForwardAuth to Pomerium, and this is one of the only two blockers I see.

@wasaga
Copy link
Collaborator

wasaga commented Jan 17, 2023

Ingress annotations are plaintext, so if we move some to CRD as default values we would definitely want them be strongly typed. like preserveHostHeader: true

this is one of the only two blockers I see

could you please make a ticket for another blocker?

@wasaga wasaga added enhancement New feature or request and removed feature labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants