Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker image for arm64v8 architecture #125

Closed
deltabweb opened this issue May 18, 2019 · 4 comments · Fixed by #127
Closed

Add docker image for arm64v8 architecture #125

deltabweb opened this issue May 18, 2019 · 4 comments · Fixed by #127
Labels
accepted good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@deltabweb
Copy link
Contributor

Hi,
Great project

It would be great if a docker image for arm64 could be added as more and more SBC are using this architecture.
I was able to build the docker image by using the existing Dockerfile.arm32v7 file and changing

ENV GOARCH=arm
ENV GOARM=7

to

ENV GOARCH=arm64
@desimone desimone added feature good first issue Good for newcomers help wanted Extra attention is needed accepted labels May 18, 2019
@desimone desimone added this to the v0.0.5 milestone May 18, 2019
@desimone
Copy link
Contributor

@deltabweb Thanks! Happy to accept a PR.

@deltabweb
Copy link
Contributor Author

deltabweb commented May 18, 2019

Sure, I can create the Dockerfile.arm64v8 file but I am unsure of what else needs to be done?

@desimone
Copy link
Contributor

desimone commented May 18, 2019 via email

@deltabweb
Copy link
Contributor Author

I have just created the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants