Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/identity: re-enable gitlab #136

Closed
jakesmolka opened this issue May 24, 2019 · 2 comments · Fixed by #518
Closed

internal/identity: re-enable gitlab #136

jakesmolka opened this issue May 24, 2019 · 2 comments · Fixed by #518
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jakesmolka
Copy link

Is your feature request related to a problem? Please describe.

The docs are saying Gitlab was removed as provider because there is no access to private emails. This seems to be fixed now: https://gitlab.com/gitlab-org/gitlab-ce/issues/44435#note_156557985

Describe the solution you'd like

I'm new here but I'd guess most old code from the former integration should work.

@desimone desimone added help wanted Extra attention is needed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 25, 2019
@desimone desimone changed the title Gitlab grants email access (again?) internal/identity: re-enable gitlab May 26, 2019
@desimone
Copy link
Contributor

I'd love to have gitlab back in the mix but probably won't have time to get to it in the near future. Would very much welcome the contribution though. Like you said, it should be very similar to the original implementation.

@desimone desimone added good first issue Good for newcomers and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 1, 2019
@thoth291
Copy link

thoth291 commented Sep 1, 2019

It seems like the only possible auth method is Gitlab for me and my clients, but that's not working, so can't use (or even try) your wonderful project... But maybe there is someone who can pick it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants