proxy: move set request headers before handle allow public access #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Code Climate has analyzed commit bc82817 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 89.4% (0.0% change). View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
======================================
Coverage 87.5% 87.5%
======================================
Files 55 55
Lines 2717 2717
======================================
Hits 2378 2378
Misses 257 257
Partials 82 82
|
desimone
approved these changes
Feb 2, 2020
desimone
changed the title
desimone
pushed a commit
that referenced
this pull request
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring policy set_request_headers ahead of handling AllowPublicUnauthenticatedAccess to avoiding set_request_headers was bypassed when AllowPublicUnauthenticatedAccess enabled.
Related issues
Fixes #477
Checklist: