Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO item: Include hashes in lock file #30

Open
cquinn opened this issue Aug 1, 2019 · 0 comments
Open

TODO item: Include hashes in lock file #30

cquinn opened this issue Aug 1, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
Required for 1.0 ...

Comments

@cquinn
Copy link
Contributor

cquinn commented Aug 1, 2019

When we locate the tag/version of a commit that we want during update, we should also record its commit hash in the lock file. We can then verify this when we fetch.

The Golang module system does this to avoid surprises caused by people moving tags around out from under people and quietly breaking builds.
@SeanTAllen SeanTAllen added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
Required for 1.0 release candidate
Development

No branches or pull requests
2 participants
@SeanTAllen @cquinn