Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context cancellation to backup routines #110

Closed
nilslice opened this issue Apr 5, 2017 · 5 comments
Closed

Add context cancellation to backup routines #110

nilslice opened this issue Apr 5, 2017 · 5 comments

Comments

@nilslice
Copy link
Contributor

nilslice commented Apr 5, 2017

When backing up components of a Ponzu system via HTTP backup utility, we should provide a cancellation context so dropped connections will stop the backup. Some backups can be very expensive, especially the tar/gzip archiving of uploads.

func backupHandler(res http.ResponseWriter, req *http.Request) {

each Backup func will need to take the req with the context added with cancellation propagation.

@eticzon
Copy link
Contributor

eticzon commented Apr 10, 2017

Hi @nilslice! Would you mind if I have crack at this? I want to trial ponzu as a CMS for personal projects. What better way to learn that to dive right in the codebase! 😄

@nilslice
Copy link
Contributor Author

Hey @eticzon - please do! Thank you & let me know if you have any questions.

@nilslice
Copy link
Contributor Author

Hi @eticzon - checking in with you on the status of this in case you had made some progress or needed help? I'll hopefully have some time this weekend for issue clean-up and this PR is on my list to get done sooner than later.

@eticzon
Copy link
Contributor

eticzon commented Apr 19, 2017

Hey @nilslice! Apologies for the delay. Yup, just familiarising myself with the overall project structure and all. I should be able to create a PR before the weekend.

@nilslice
Copy link
Contributor Author

Awesome. I didn't mean any rush, just figured I'd ask and avoid duplicating efforts. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants