Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small food-colored vertical line is visible when customer eats #49

Closed
Poobslag opened this issue Mar 25, 2020 · 1 comment · Fixed by #368
Closed

Small food-colored vertical line is visible when customer eats #49

Poobslag opened this issue Mar 25, 2020 · 1 comment · Fixed by #368
Labels
bug Something isn't working priority-4 This is less noticable. If we run out of other things to do, it's something to consider.

Comments

@Poobslag
Copy link
Owner

When the customer is fed, there's a 1-pixel wide vertical line briefly visible. This is because the "hurled food" sprites don't have a border. They need to be reexported with a 1px border similar to the block sprites.

@Poobslag Poobslag added the bug Something isn't working label Mar 25, 2020
@Poobslag Poobslag assigned Poobslag and unassigned Poobslag Mar 25, 2020
@Poobslag Poobslag added the priority-4 This is less noticable. If we run out of other things to do, it's something to consider. label May 1, 2020
@Poobslag
Copy link
Owner Author

Poobslag commented May 2, 2020

The 'hurled food' sprites now have a 1px border as seen here but the problem persists. It's possible it's an issue here because the sprite is scaled to 500% width, so the extrusion needs to be wider as well.

I've seen some other similar bugs which are barely noticable throughout the game. Once in a blue moon, I swear I see a small seam when rotating a puzzle piece. I also have vague recollections of small 1px artifacts when resizing/scaling customer related sprites which brushed too close to a border, even if they were properly padded and extruded.

I believe our extrusions and gaps need to be larger than 1px -- maybe we could make them more like 5px just to rule this out entirely. If we still see a problem when our extrusions are that large, then at least we know we need to fix the problem a different way.

@Poobslag Poobslag linked a pull request Jun 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-4 This is less noticable. If we run out of other things to do, it's something to consider.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant