Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated resources should go in a dedicated folder #64

Closed
Poobslag opened this issue Mar 29, 2020 · 1 comment
Closed

Generated resources should go in a dedicated folder #64

Poobslag opened this issue Mar 29, 2020 · 1 comment
Labels
technical debt Something which works fine now, but will create more work in the future

Comments

@Poobslag
Copy link
Owner

Currently, the top-level directory includes configuration files, resources and readmes but it also contains Turbo Fat.exe, Turbo Fat.pck and Turbo Fat.x86_64 files. These compiled artifacts should go in some kind of a generated bin, output, target or similar directory. If godot has a convention for this, we should follow it.

This directory's contents should also be in the gitignore. I've currently had some close calls almost adding huge 50 MB zip files to .git by mistake because we do not follow this practice.
@Poobslag Poobslag added the technical debt Something which works fine now, but will create more work in the future label Mar 29, 2020
@Poobslag
Copy link
Owner Author

Fixed in commit be43cf0. Resources are now exported to the /export folder. The gitignore remains unmodified, but could possibly be changed to ignore /export/* or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt Something which works fine now, but will create more work in the future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Poobslag