Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Stacks Designs #39

Closed
isaac-8601 opened this issue Jul 28, 2022 · 5 comments
Closed

New Stacks Designs #39

isaac-8601 opened this issue Jul 28, 2022 · 5 comments
Assignees

Comments

@isaac-8601
Copy link

isaac-8601 commented Jul 28, 2022

This issue is a design proposal to update the visual style of our stacks (what we've called our tabbed windows in Pop!_OS), and to update some behaviors and add new functionality. Users should be able to move both tabs of a stack, and also the entire stack itself, with both the keyboard and the mouse.

When changing the focus from one particular tab to a window outside the stack using the keyboard, there are many cases in which the focus of the stack will be on a tab the user does not want active. We're proposing a new behavior for changing focus from inside to outside a stack, detailed later in this issue.

We also want to improve the visual clarity of tabs and make it clearer which apps are currently in the stack.

Designs

To improve clarity of the stacks, tabs will now have application icons, and the stack header itself will have a stack icon on the left. Users can use the spaces left and right of the tabs to drag the stack with their mouse. Behavior while dragging should match that of other windows indicated in this issue. Moving an entire stack with the keyboard will also be possible after using the Select Outward keyboard shortcut and behavior should match other windows with our new keyboard shortcut and tiling.

stack-header

When a user has several tabs and/or the length of the title exceeds the tab width, the title will go past the visible edge and a slight gradient will come over the title from the right side.

stack-header-many-tabs

We also propose new behavior for what happens when you hold down the Super key while moving focus outside of the stack. In the current system, focus remains on the most-recently focused tab, even if the user intended to change the active window without changing which tab was active in the stack. Our proposal is that the behavior of releasing the Super key inside a stack will be unchanged; initiating window focus change inside a stack but releasing the Super key outside of a stack will change window focus to the new window, but the stack will present the tab that was active when the Super key was first pressed.

Single items can still move in and out of stacks, similar to current behavior. One change we will implement is animation in which tabs appear in the stack and move through the stack header along with the arrow keys.

stack-1

@isaac-8601 isaac-8601 changed the title # New Stacks Designs New Stacks Designs Jul 28, 2022
@silmarillion1337
Copy link

I hope there will be an option to move the tabs to the bottom of a window. I prefer a taskbar to a dock so if the tabs are at the bottom it'll be like a taskbar.

@maria-komarova
Copy link

It's an interesting suggestion, we'll definitely consider it. It would also be helpful to learn how many people would like that option.

@maria-komarova
Copy link

We've been reviewing window stack headers because of some other questions but we realized there were a few things missing from the designs. So we've adjusted the designs for the window tabs and stack headers to account for it.

  • Window tabs now include the Close button and therefore app icon and window title are left-aligned inside the tab and close button is right aligned.

  • Window tabs now have more states to make sure one can differentiate between selected tabs inside the active window stack and an inactive one.
    Two-stacks-light
    Two-stacks-dark-1

  • We've adjusted the colors to better align with the current state of COSMIC design system.

  • Tab overflow behavior was revisited and better outlined in the detailed prototype:
    window-tab-overflow

@isaac-8601
Copy link
Author

We've made another addition to window stacks in line with the "Select Outward" shortcut. Since we'll be able to use those shortcuts to move from an individual tab focus to a whole stack focus, the stack header should reflect that state. However, it will still need to be clear which tab is being displayed on this stack, even when the whole stack is selected.

Light mode:
Light theme stack header for whole stack selection

Dark mode:
Dark theme stack header for whole stack selection

When the stack is selected, the start and end areas of the stack get the accent color and on_accent text color, and there's a small accent border on the bottom. The tab that is currently displaying has semi-bold weight and accent_text_color styling.

@Solarunit
Copy link

Solarunit commented Jun 16, 2023

I like this idea, I remember MS was planning to add similar feature to Windows for years..
But I would rather like to have a real Task List on the Panel at the bottom. I am not a dock user at all.

Some ideas about stacked tabs:

  • small (initial) tabs, do not expand them to the whole window size
  • option to close tab by middle click
  • option to hide close x button (to avoid accidental tabs closing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants