Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only first panel applet rendering on Nvidia 1650 gaze15 #13

Closed
ids1024 opened this issue Sep 1, 2022 · 8 comments
Closed

Only first panel applet rendering on Nvidia 1650 gaze15 #13

ids1024 opened this issue Sep 1, 2022 · 8 comments

Comments

@ids1024
Copy link
Member

ids1024 commented Sep 1, 2022

After updating to the latest commit of cosmic-panel (and master staging builds of everything else), the segfault from #12 seems to be addressed, but I seem to see only the first applet in each panel being rendered. Popups open fine, and behavior is otherwise as expected.

Is something not working with creating multiple EGLSurfaces from the panel WlSurface? Not sure exactly how to debug this sort of behavior.

eDP-1_1662053040
eDP-1_1662053044
eDP-1_1662053047

@ids1024
Copy link
Member Author

ids1024 commented Sep 1, 2022

Hm, seems to happen on the same system booted in integrated mode? I tested that just to double check even though it obviously has to be graphics driver related...

Not sure what could cause this.

@ids1024
Copy link
Member Author

ids1024 commented Sep 1, 2022

Ah, I think this is just a theme issue. Not sure what is determining the colors here, but the panel text and icons are black on a black panel.

@wash2
Copy link
Collaborator

wash2 commented Sep 1, 2022

Oh I think I understand why this is happening. The panel and apps should be using the colors in ~/.config/gtk-4.0/cosmic.css or adwaita defaults for the currently active dark/light mode. All of the panel buttons and such are pretty much transparent though, and if the panel is black in light mode, which based on the popup, it probably is, then the text would be black on a transparent widget on a black panel.

@ids1024
Copy link
Member Author

ids1024 commented Sep 1, 2022

Yep. Looks like this is (partly) from having the dconf setting /org/gnome/desktop/interface/color-scheme set to prefer-light. It looks correct with prefer-dark.

Though the panel is also black on this computer, and gray on my other laptop. I don't know what determines the panel background color given neither computer has a ~/.config/gtk-4.0/cosmic.css file currently.

On both computers, changing color-scheme changes how the applets look but not the panel background. Presumably it should change either both or neither.

@wash2
Copy link
Collaborator

wash2 commented Sep 1, 2022

It should depend on your config, if you have one. One computer might be using ThemeDefault and another could be using a custom color? It's possible that the default that it loads in absence of a cosmic.css might be an issue.

@ids1024
Copy link
Member Author

ids1024 commented Sep 2, 2022

Okay, building for git I get the same black color on both.

Since the default config is ThemeDefault(Some(0.8)), shouldn't there be opacity? The the default panel config and no cosmic.css it seems to be black with no opacity.

@wash2
Copy link
Collaborator

wash2 commented Sep 6, 2022

Ok latest should fix it.

On another note, maybe instead of the panel, gtk apps, and iced apps watching both the palette files + theme dark / light setting, the palette could be exposed from the user color editor via dbus for each toolkit that we might use, like iced-palette, adwaita-palette, etc... ?

@ids1024
Copy link
Member Author

ids1024 commented Sep 6, 2022

We'll want apps using Cosmic styling to be usable outside of the Cosmic desktop, so they probably shouldn't rely on the existence of a special dbus service. That use case is something to consider for any solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants