Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings > Wallpapers #16

Closed
WatchMkr opened this issue Jun 2, 2022 · 8 comments
Closed

Settings > Wallpapers #16

WatchMkr opened this issue Jun 2, 2022 · 8 comments
Assignees

Comments

@WatchMkr
Copy link

WatchMkr commented Jun 2, 2022

No description provided.

@WatchMkr
Copy link
Author

WatchMkr commented Jun 2, 2022

Features for pop-os/cosmic-epoch#18 are derived from this panel.

@maria-komarova
Copy link

maria-komarova commented Jan 11, 2023

The Wallpaper panel in COSMIC Settings is where users can choose a background image and a color for their displays, or set the background to cycle through the slideshow.

Wallpaper-defaults

Background options

The panel provides an ability to choose a background from:

  • System backgrounds (a set of images that comes with the system)
  • Colors (a set of solid colors that could be deleted or added)
  • A folder from the Files system on the device that a user can open through the Files application.
    Any of these sets of backgrounds could be toggled to a slideshow.

background options

There is also a button to add image/color available. After clicking the button and either choosing an individual image from the Files or selecting a color from the color picker, it is immediately applied as the background and added as the first item in the grid with the selected state. For System backgrounds, only images the user adds intentionally are the ones that can be removed.

delete-added-image
The mockup above shows wallpaper panel after an image has been added and is now deleted.

Slideshow

When Slideshow is toggled on, there is an additional List Item with the dropdown for setting the time when the image should change. Options include 5 minutes, 10 minutes, 15 minutes, 30 minutes, 1 hour, 2 hours. All the images become available for multiple selection - one can add/remove them from the slides how by clicking/tapping on them.

slideshow

Setting different wallpaper per display

The mockups include a function to set different wallpaper on each display. Un-toggling “Same background on all displays” enables tabs for each display that allow setting different backgrounds.

different-per-display

Design mockups and notes are here.

@Sporesirius
Copy link

First of all, many thanks to the whole Pop OS team for all their hard work. It looks really good.

Will animated wallpapers also be supported?

@bluthej
Copy link

bluthej commented Feb 22, 2023

Very excited about the new DE!

One thing that I have learned to love while using Sway as my WM is to have a wallpaper picked at random whenever the WM is started. It's super easy to do.
There are some python and bash scripts that replicate that behavior in other environments but it would be nice to have that as an option in the settings :)
Just putting it out there

@Macdhai
Copy link

Macdhai commented May 11, 2023

For the slideshow wallpaper feature, will users be able to add additional folders to pull from, or will they be restricted to files in the default backgrounds folder?

@WatchMkr
Copy link
Author

WatchMkr commented Sep 13, 2023

Checklist to match design features and functions:

  • Bug: Wallpaper panel scrolls infinitely
  • Bug: Wallpaper per display - clicking the second display flips the backgrounds (tested with only two displays)
  • Add selected indicator to the bottom left of the selected background image
  • "Add image" text label and open file chooser/add image for System backgrounds
  • Ability to delete the added image (@maria-komarova probably should be the trash icon instead of X for close)
  • "Add color" text label and open color picker for Colors
  • Ability to delete the added color (probably should be the trash icon instead of X for close)
  • When Slideshow is active, add select boxes to the images (all images selected by default)
  • Retain selected backgrounds state when Slideshow is toggled off
  • Change all instances of "Background" to "Wallpaper". "Same background on...", "Background fit", and "System backgrounds" should all be "wallpapers/wallpapers"
  • Background fit: remove "Stretch:
  • Background fit: rename "Zoom" to "Fill"
  • Always default to "Fill"

@maria-komarova
Copy link

One more thing - the design uses tabs for switching the view between the displays rather than the segmented control/button. This is more consistent with other instances in the designs, for example, on the Displays panel.

@WatchMkr
Copy link
Author

WatchMkr commented Dec 15, 2023

Feature wrap-up list here: closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Alpha 1 Complete
Development

No branches or pull requests

8 participants