Broken boot configuration for installation into encrypted partitions (whole disk install not affected)

[philstopford]

Distribution (run cat /etc/os-release):

NAME="Pop!_OS"
VERSION="22.04 LTS"
ID=pop
ID_LIKE="ubuntu debian"
PRETTY_NAME="Pop!_OS 22.04 LTS"
VERSION_ID="22.04"
HOME_URL="https://pop.system76.com"
SUPPORT_URL="https://support.system76.com"
BUG_REPORT_URL="https://github.com/pop-os/pop/issues"
PRIVACY_POLICY_URL="https://system76.com/privacy"
VERSION_CODENAME=jammy
UBUNTU_CODENAME=jammy
LOGO=distributor-logo-pop-os

Related Application and/or Package Version (run apt policy $PACKAGE NAME):

Installer

Issue/Bug Description:

Installing with encryption (without taking the whole disk) fails to set up the /etc/crypttab and /etc/fstab correctly. Without encryption, no issue is seen. Installing with encryption to an entire disk is also fine.

Steps to reproduce (if you know):

Boot from released image into live desktop
Install to a specific (new or existing) LUKS partition, opting to format the internal volume to ext4.
When you reboot post-install, the system will drop to busybox because the boot process is not set-up.

On inspection, /etc/crypttab will be blank and /etc/fstab will be pointing at the LUKS UUID for root whilst declaring it ext4.

Recovery requires booting into live environment again, to mount the LUKS volume and /boot/efi. On chroot-ing into the broken system, /etc/crypttab and /etc/fstab need to be edited and update-initramfs used to fix up the load.

Expected behavior:

On any installation to an encrypted volume, the installer should recognize this and ensure the installation has the required entries in /etc/crypttab and /etc/fstab to allow a successful boot.

Other Notes:

Ubuntu fixed this for the first time in their 22.04 release (prior releases would fail to set things up properly) and Linux Mint handles this properly, in case implementation references might be useful.