Added compatibility for non-MacOS X developers #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ems will fail npm install. See npm/npm#14042
outoftime
requested changes
Oct 16, 2016
| @@ -0,0 +1,6 @@ | |||
| * text eol=lf | |||
| @@ -2,3 +2,4 @@ static/compiled | |||
| node_modules | |||
| npm-debug.log | |||
| bower_components | |||
| *.idea | |||
There was a problem hiding this comment.
I think it’s best to use a global excludes file to keep out artifacts generated by the editor of your choice—hence no .swp etc. in here even though I’m a vim user. Would that work for you?
| @@ -130,6 +130,7 @@ for all the sordid details. | |||
| * [Alejandro AR](https://github.com/kinduff) | |||
| * [Vaibhav Verma](https://github.com/v) | |||
| * [Alex Pelan](https://github.com/alexpelan) | |||
| * [Jesse Wang](https://github.com/jwang1919) | |||
There was a problem hiding this comment.
Be sure to add yourself to the package.json as well!
There was a problem hiding this comment.
Ahh didn't notice* another contributors section!
…f as contributor to package.json
outoftime
approved these changes
Oct 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs involved with developing this project on Windows. These fixes should also apply for Linux developers but can't confirm it.
Bugs Fixed:
npm installwill fail when attempting to install fsevents dependencySee: npm/npm#14042
npm testwill fail because of CRLF linebreaksBug looks like this: sindresorhus/matcher#4
Fixed using .gitattributes: https://help.github.com/articles/dealing-with-line-endings/
Also added
*.ideafor IntelliJ developers =)