[FR] Add "Toggle subtitles" keyboard shortcut

[ImAnnoying2]

Operating System Version:

All
Popcorn Time Version:

0.3.10
Download date:

07.08.2018

I suggest adding a keyboard shortcut that toggles subtitles on and off, like in VLC. Manually choosing to play videos in VLC is detrimental to the overall "all-in-one" user experience...

[Fantomas4]

I would like to give this a try! I will post here if I manage to come up with a proper solution.

[Persei08]

I don't know. For me what he is asking isn't a shortcut to cycles through subtitles but more something to disable and re-enable them.

I think @ImAnnoying2 should clarify what he want

[Persei08]

yeah I wonder if having a keyboard shortcut for that is really useful, because you can disable subtitles in 2 clicks or you can choose to not enable subtitles by default and then enable them when playing in 2 clicks :/ .

In fact i don't see why someone should disable or enable subtitle often. So if @ImAnnoying2 don't provide more infos, I think we will close it until someone ask again

[dutchy1001]

I agree here with @Persei08 you either have subs on or off.

Does PCT have the option to change the the speed (in milliseconds) to let the subs go faster or slower when their out of sync?
That would be the only reason for me to turn subs off if that option is not build in. I do use subs all the time with an external player that does have this option (it also let me change the subs if I have a "better" file (see my last comment at #1540 were I explain this)).

[dutchy1001]

@dutchy1001 You mean this ?

Yea, I just went to the list of issue e-mails were this was answered lol

Now is #1332 and yeah, that would be a nice feature to have.

When using an external player it is not up to PCT to implement that, that is the external players job, like I mention in #1540 .
If you want something like that implemented into PCT then that is up to you guys.

[dutchy1001]

if Popcorn Time can inject a subtitle in the stream while using an external player

When using the external player, in my case SMPlayer, the SMPlayer is connecting to Opensubtitles.org if I want to change the subs not PCT, so when changing the subs it's not injected from PCT anymore.

After starting the player, I presume this is streaming, there is no option in PCT to change subs unless you restart the movie.

When casting you will have your Android phone/tablet or pc/linux/mac to cast it to (most likely) a tv, meaning you still have your casting device were you can change settings, if there are any (almost like a remote control then).

Am I thinking to far now or do I make sense?? (after all it's Friday, I need a drink)