Various cppcheck perf fixes

popcornmix · Jul 3, 2015 · 55a9105 · 55a9105
1 parent 332c2cd
commit 55a9105
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 15 deletions.
diff --git a/xbmc/interfaces/json-rpc/JSONUtils.h b/xbmc/interfaces/json-rpc/JSONUtils.h
@@ -515,7 +515,7 @@ namespace JSONRPC
         return;
 
       stringArray.clear();
-      for (CVariant::const_iterator_array it = jsonStringArray.begin_array(); it != jsonStringArray.end_array(); it++)
+      for (CVariant::const_iterator_array it = jsonStringArray.begin_array(); it != jsonStringArray.end_array(); ++it)
         stringArray.push_back(it->asString());
     }
 

diff --git a/xbmc/storage/DetectDVDType.cpp b/xbmc/storage/DetectDVDType.cpp
@@ -64,14 +64,14 @@ CDetectDVDMedia* CDetectDVDMedia::m_pInstance = NULL;
 std::string CDetectDVDMedia::m_diskLabel = "";
 std::string CDetectDVDMedia::m_diskPath = "";
 
-CDetectDVDMedia::CDetectDVDMedia() : CThread("DetectDVDMedia")
+CDetectDVDMedia::CDetectDVDMedia() : CThread("DetectDVDMedia"),
+  m_bStartup(true),  // Do not autorun on startup
+  m_bAutorun(false),
+  m_dwLastTrayState(0),
+  m_cdio(CLibcdio::GetInstance())
 {
-  m_bAutorun = false;
   m_bStop = false;
-  m_dwLastTrayState = 0;
-  m_bStartup = true;  // Do not autorun on startup
   m_pInstance = this;
-  m_cdio = CLibcdio::GetInstance();
 }
 
 CDetectDVDMedia::~CDetectDVDMedia()

diff --git a/xbmc/utils/HttpRangeUtils.cpp b/xbmc/utils/HttpRangeUtils.cpp
@@ -261,7 +261,7 @@ bool CHttpRanges::Parse(const std::string& header, uint64_t totalLength)
   // split the value of the "Range" header by ","
   std::vector<std::string> rangeValues = StringUtils::Split(rangesValue, ",");
 
-  for (std::vector<std::string>::const_iterator range = rangeValues.begin(); range != rangeValues.end(); range++)
+  for (std::vector<std::string>::const_iterator range = rangeValues.begin(); range != rangeValues.end(); ++range)
   {
     // there must be a "-" in the range definition
     if (range->find("-") == std::string::npos)

diff --git a/xbmc/video/dialogs/GUIDialogSubtitles.cpp b/xbmc/video/dialogs/GUIDialogSubtitles.cpp
@@ -97,13 +97,12 @@ class CSubtitlesJob: public CJob
 
 CGUIDialogSubtitles::CGUIDialogSubtitles(void)
     : CGUIDialog(WINDOW_DIALOG_SUBTITLES, "DialogSubtitles.xml")
+    , m_subtitles(new CFileItemList)
+    , m_serviceItems(new CFileItemList)
+    , m_pausedOnRun(false)
+    , m_updateSubsList(false)
 {
-  m_loadType  = KEEP_IN_MEMORY;
-  m_subtitles = new CFileItemList;
-  m_serviceItems = new CFileItemList;
-  m_pausedOnRun = false;
-  m_updateSubsList = false;
-  m_LastAutoDownloaded = "";
+  m_loadType = KEEP_IN_MEMORY;
 }
 
 CGUIDialogSubtitles::~CGUIDialogSubtitles(void)

diff --git a/xbmc/video/videosync/VideoSyncIos.cpp b/xbmc/video/videosync/VideoSyncIos.cpp
@@ -32,14 +32,13 @@
 bool CVideoSyncIos::Setup(PUPDATECLOCK func)
 {
   CLog::Log(LOGDEBUG, "CVideoSyncIos::%s setting up OSX", __FUNCTION__);
-  bool setupOk = false;
 
   //init the vblank timestamp
   m_LastVBlankTime = CurrentHostCounter();
   UpdateClock = func;
   m_abort = false;
 
-  setupOk = InitDisplayLink();
+  bool setupOk = InitDisplayLink();
   if (setupOk)
   {
     g_Windowing.Register(this);