forked from SeldonIO/seldon-core
/
seldondeployment_controller.go
1489 lines (1310 loc) · 50.9 KB
/
seldondeployment_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
Copyright 2019 The Seldon Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package controllers
import (
"bytes"
"context"
"fmt"
types2 "github.com/gogo/protobuf/types"
"github.com/seldonio/seldon-core/operator/constants"
"github.com/seldonio/seldon-core/operator/utils"
"k8s.io/apimachinery/pkg/api/equality"
"k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/intstr"
"knative.dev/pkg/kmp"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"strconv"
"strings"
"github.com/go-logr/logr"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
machinelearningv1 "github.com/seldonio/seldon-core/operator/apis/machinelearning/v1"
"encoding/json"
istio_networking "istio.io/api/networking/v1alpha3"
istio "istio.io/client-go/pkg/apis/networking/v1alpha3"
appsv1 "k8s.io/api/apps/v1"
autoscaling "k8s.io/api/autoscaling/v2beta1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
const (
ENV_DEFAULT_ENGINE_SERVER_PORT = "ENGINE_SERVER_PORT"
ENV_DEFAULT_ENGINE_SERVER_GRPC_PORT = "ENGINE_SERVER_GRPC_PORT"
ENV_CONTROLLER_ID = "CONTROLLER_ID"
DEFAULT_ENGINE_CONTAINER_PORT = 8000
DEFAULT_ENGINE_GRPC_PORT = 5001
AMBASSADOR_ANNOTATION = "getambassador.io/config"
LABEL_CONTROLLER_ID = "seldon.io/controller-id"
)
// SeldonDeploymentReconciler reconciles a SeldonDeployment object
type SeldonDeploymentReconciler struct {
client.Client
Log logr.Logger
Scheme *runtime.Scheme
Namespace string
}
//---------------- Old part
type components struct {
serviceDetails map[string]*machinelearningv1.ServiceStatus
deployments []*appsv1.Deployment
services []*corev1.Service
hpas []*autoscaling.HorizontalPodAutoscaler
virtualServices []*istio.VirtualService
destinationRules []*istio.DestinationRule
}
type serviceDetails struct {
svcName string
deploymentName string
svcUrl string
ambassadorUrl string
}
type httpGrpcPorts struct {
httpPort int
grpcPort int
}
func createHpa(podSpec *machinelearningv1.SeldonPodSpec, deploymentName string, seldonId string, namespace string) *autoscaling.HorizontalPodAutoscaler {
hpa := autoscaling.HorizontalPodAutoscaler{
ObjectMeta: metav1.ObjectMeta{
Name: deploymentName,
Namespace: namespace,
Labels: map[string]string{machinelearningv1.Label_seldon_id: seldonId},
},
Spec: autoscaling.HorizontalPodAutoscalerSpec{
ScaleTargetRef: autoscaling.CrossVersionObjectReference{
Name: deploymentName,
APIVersion: "apps/v1",
Kind: "Deployment",
},
MaxReplicas: podSpec.HpaSpec.MaxReplicas,
Metrics: podSpec.HpaSpec.Metrics,
},
}
if podSpec.HpaSpec.MinReplicas != nil {
hpa.Spec.MinReplicas = podSpec.HpaSpec.MinReplicas
}
return &hpa
}
// Create istio virtual service and destination rule.
// Creates routes for each predictor with traffic weight split
func createIstioResources(mlDep *machinelearningv1.SeldonDeployment,
seldonId string,
namespace string,
ports []httpGrpcPorts,
httpAllowed bool,
grpcAllowed bool) ([]*istio.VirtualService, []*istio.DestinationRule, error) {
istio_gateway := GetEnv(ENV_ISTIO_GATEWAY, "seldon-gateway")
istioTLSMode := GetEnv(ENV_ISTIO_TLS_MODE, "")
istioRetriesAnnotation := getAnnotation(mlDep, ANNOTATION_ISTIO_RETRIES, "")
istioRetriesTimeoutAnnotation := getAnnotation(mlDep, ANNOTATION_ISTIO_RETRIES_TIMEOUT, "1")
istioRetries := 0
istioRetriesTimeout := 1
var err error
if istioRetriesAnnotation != "" {
istioRetries, err = strconv.Atoi(istioRetriesAnnotation)
if err != nil {
return nil, nil, err
}
istioRetriesTimeout, err = strconv.Atoi(istioRetriesTimeoutAnnotation)
if err != nil {
return nil, nil, err
}
}
httpVsvc := &istio.VirtualService{
ObjectMeta: metav1.ObjectMeta{
Name: seldonId + "-http",
Namespace: namespace,
},
Spec: istio_networking.VirtualService{
Hosts: []string{"*"},
Gateways: []string{getAnnotation(mlDep, ANNOTATION_ISTIO_GATEWAY, istio_gateway)},
Http: []*istio_networking.HTTPRoute{
{
Match: []*istio_networking.HTTPMatchRequest{
{
Uri: &istio_networking.StringMatch{MatchType: &istio_networking.StringMatch_Prefix{Prefix: "/seldon/" + namespace + "/" + mlDep.Name + "/"}},
},
},
Rewrite: &istio_networking.HTTPRewrite{Uri: "/"},
},
},
},
}
grpcVsvc := &istio.VirtualService{
ObjectMeta: metav1.ObjectMeta{
Name: seldonId + "-grpc",
Namespace: namespace,
},
Spec: istio_networking.VirtualService{
Hosts: []string{"*"},
Gateways: []string{getAnnotation(mlDep, ANNOTATION_ISTIO_GATEWAY, istio_gateway)},
Http: []*istio_networking.HTTPRoute{
{
Match: []*istio_networking.HTTPMatchRequest{
{
Uri: &istio_networking.StringMatch{MatchType: &istio_networking.StringMatch_Regex{Regex: constants.GRPCRegExMatchIstio}},
Headers: map[string]*istio_networking.StringMatch{
"seldon": &istio_networking.StringMatch{MatchType: &istio_networking.StringMatch_Exact{Exact: mlDep.Name}},
"namespace": &istio_networking.StringMatch{MatchType: &istio_networking.StringMatch_Exact{Exact: namespace}},
},
},
},
},
},
},
}
// Add retries
if istioRetries > 0 {
httpVsvc.Spec.Http[0].Retries = &istio_networking.HTTPRetry{Attempts: int32(istioRetries), PerTryTimeout: &types2.Duration{Seconds: int64(istioRetriesTimeout)}, RetryOn: "gateway-error,connect-failure,refused-stream", RetryRemoteLocalities: &types2.BoolValue{Value: true}}
grpcVsvc.Spec.Http[0].Retries = &istio_networking.HTTPRetry{Attempts: int32(istioRetries), PerTryTimeout: &types2.Duration{Seconds: int64(istioRetriesTimeout)}, RetryOn: "gateway-error,connect-failure,refused-stream", RetryRemoteLocalities: &types2.BoolValue{Value: true}}
}
// shadows don't get destinations in the vs as a shadow is a mirror instead
var shadows int = 0
for i := 0; i < len(mlDep.Spec.Predictors); i++ {
p := mlDep.Spec.Predictors[i]
if p.Shadow == true {
shadows += 1
}
}
routesHttp := make([]*istio_networking.HTTPRouteDestination, len(mlDep.Spec.Predictors)-shadows)
routesGrpc := make([]*istio_networking.HTTPRouteDestination, len(mlDep.Spec.Predictors)-shadows)
// the shdadow/mirror entry does need a DestinationRule though
drules := make([]*istio.DestinationRule, len(mlDep.Spec.Predictors))
routesIdx := 0
for i := 0; i < len(mlDep.Spec.Predictors); i++ {
p := mlDep.Spec.Predictors[i]
pSvcName := machinelearningv1.GetPredictorKey(mlDep, &p)
drule := &istio.DestinationRule{
ObjectMeta: metav1.ObjectMeta{
Name: pSvcName,
Namespace: namespace,
},
Spec: istio_networking.DestinationRule{
Host: pSvcName,
Subsets: []*istio_networking.Subset{
{
Name: p.Name,
Labels: map[string]string{
"version": p.Labels["version"],
},
},
},
},
}
if istioTLSMode != "" {
drule.Spec.TrafficPolicy = &istio_networking.TrafficPolicy{
Tls: &istio_networking.TLSSettings{
Mode: istio_networking.TLSSettings_TLSmode(istio_networking.TLSSettings_TLSmode_value[istioTLSMode]),
},
}
}
drules[i] = drule
if p.Shadow == true {
//if there's a shadow then add a mirror section to the VirtualService
httpVsvc.Spec.Http[0].Mirror = &istio_networking.Destination{
Host: pSvcName,
Subset: p.Name,
Port: &istio_networking.PortSelector{
Number: uint32(ports[i].httpPort),
},
}
grpcVsvc.Spec.Http[0].Mirror = &istio_networking.Destination{
Host: pSvcName,
Subset: p.Name,
Port: &istio_networking.PortSelector{
Number: uint32(ports[i].grpcPort),
},
}
continue
}
//we split by adding different routes with their own Weights
//so not by tag - different destinations (like https://istio.io/docs/tasks/traffic-management/traffic-shifting/) distinguished by host
routesHttp[routesIdx] = &istio_networking.HTTPRouteDestination{
Destination: &istio_networking.Destination{
Host: pSvcName,
Subset: p.Name,
Port: &istio_networking.PortSelector{
Number: uint32(ports[i].httpPort),
},
},
Weight: p.Traffic,
}
routesGrpc[routesIdx] = &istio_networking.HTTPRouteDestination{
Destination: &istio_networking.Destination{
Host: pSvcName,
Subset: p.Name,
Port: &istio_networking.PortSelector{
Number: uint32(ports[i].grpcPort),
},
},
Weight: p.Traffic,
}
routesIdx += 1
}
httpVsvc.Spec.Http[0].Route = routesHttp
grpcVsvc.Spec.Http[0].Route = routesGrpc
if httpAllowed && grpcAllowed {
vscs := make([]*istio.VirtualService, 2)
vscs[0] = httpVsvc
vscs[1] = grpcVsvc
return vscs, drules, nil
} else if httpAllowed {
vscs := make([]*istio.VirtualService, 1)
vscs[0] = httpVsvc
return vscs, drules, nil
} else {
vscs := make([]*istio.VirtualService, 1)
vscs[0] = grpcVsvc
return vscs, drules, nil
}
}
func getEngineHttpPort() (engine_http_port int, err error) {
// Get engine http port from environment or use default
engine_http_port = DEFAULT_ENGINE_CONTAINER_PORT
var env_engine_http_port = GetEnv(ENV_DEFAULT_ENGINE_SERVER_PORT, "")
if env_engine_http_port != "" {
engine_http_port, err = strconv.Atoi(env_engine_http_port)
if err != nil {
return 0, err
}
}
return engine_http_port, nil
}
func getEngineGrpcPort() (engine_grpc_port int, err error) {
// Get engine grpc port from environment or use default
engine_grpc_port = DEFAULT_ENGINE_GRPC_PORT
var env_engine_grpc_port = GetEnv(ENV_DEFAULT_ENGINE_SERVER_GRPC_PORT, "")
if env_engine_grpc_port != "" {
engine_grpc_port, err = strconv.Atoi(env_engine_grpc_port)
if err != nil {
return 0, err
}
}
return engine_grpc_port, nil
}
// Create all the components (Deployments, Services etc)
func createComponents(r *SeldonDeploymentReconciler, mlDep *machinelearningv1.SeldonDeployment, log logr.Logger) (*components, error) {
c := components{}
c.serviceDetails = map[string]*machinelearningv1.ServiceStatus{}
seldonId := machinelearningv1.GetSeldonDeploymentName(mlDep)
namespace := getNamespace(mlDep)
engine_http_port, err := getEngineHttpPort()
if err != nil {
return nil, err
}
engine_grpc_port, err := getEngineGrpcPort()
if err != nil {
return nil, err
}
// variables to collect what ports will be exposed and whether we should expose http and grpc externally
// If one of the predictors has noEngine then only one of http or grpc should be allowed dependent on
// the type of the noEngine model: whether it is http or grpc
externalPorts := make([]httpGrpcPorts, len(mlDep.Spec.Predictors))
grpcAllowed := true
httpAllowed := true
// Attempt to set httpAllowed and grpcAllowed to false if we have an noEngine predictor
for i := 0; i < len(mlDep.Spec.Predictors); i++ {
p := mlDep.Spec.Predictors[i]
_, noEngine := p.Annotations[machinelearningv1.ANNOTATION_NO_ENGINE]
if noEngine && len(p.ComponentSpecs) > 0 && len(p.ComponentSpecs[0].Spec.Containers) > 0 {
pu := machinelearningv1.GetPredictiveUnit(p.Graph, p.ComponentSpecs[0].Spec.Containers[0].Name)
if pu != nil {
if pu.Endpoint != nil && pu.Endpoint.Type == machinelearningv1.GRPC {
httpAllowed = false
}
if pu.Endpoint == nil || pu.Endpoint.Type == machinelearningv1.REST {
grpcAllowed = false
}
}
}
}
for i := 0; i < len(mlDep.Spec.Predictors); i++ {
p := mlDep.Spec.Predictors[i]
_, noEngine := p.Annotations[machinelearningv1.ANNOTATION_NO_ENGINE]
pSvcName := machinelearningv1.GetPredictorKey(mlDep, &p)
log.Info("pSvcName", "val", pSvcName)
// Add engine deployment if separate
_, hasSeparateEnginePod := mlDep.Spec.Annotations[machinelearningv1.ANNOTATION_SEPARATE_ENGINE]
if hasSeparateEnginePod && !noEngine {
deploy, err := createEngineDeployment(mlDep, &p, pSvcName, engine_http_port, engine_grpc_port)
if err != nil {
return nil, err
}
c.deployments = append(c.deployments, deploy)
}
for j := 0; j < len(p.ComponentSpecs); j++ {
cSpec := mlDep.Spec.Predictors[i].ComponentSpecs[j]
// if no container spec then nothing to create at this point - prepackaged model server cases handled later
if len(cSpec.Spec.Containers) == 0 {
continue
}
// create Deployment from podspec
depName := machinelearningv1.GetDeploymentName(mlDep, p, cSpec, j)
deploy := createDeploymentWithoutEngine(depName, seldonId, cSpec, &p, mlDep)
// Add HPA if needed
if cSpec.HpaSpec != nil {
c.hpas = append(c.hpas, createHpa(cSpec, depName, seldonId, namespace))
} else {
deploy.Spec.Replicas = &p.Replicas
}
// create services for each container
for k := 0; k < len(cSpec.Spec.Containers); k++ {
var con *corev1.Container
// get the container on the created deployment, as createDeploymentWithoutEngine will have created as a copy of the spec in the manifest and added defaults to it
// we need the reference as we may have to modify the container when creating the Service (e.g. to add probes)
con = utils.GetContainerForDeployment(deploy, cSpec.Spec.Containers[k].Name)
// engine will later get a special predictor service as it is entrypoint for graph
// and no need to expose tfserving container as it's accessed via proxy
if con.Name != EngineContainerName && con.Name != constants.TFServingContainerName {
// service for hitting a model directly, not via engine - also adds ports to container if needed
svc := createContainerService(deploy, p, mlDep, con, c)
if svc != nil {
c.services = append(c.services, svc)
} else {
// a user-supplied container may not be a pu so we may not create service for that
log.Info("Not creating container service for " + con.Name)
continue
}
if noEngine {
deploy.ObjectMeta.Labels[machinelearningv1.Label_seldon_app] = pSvcName
deploy.Spec.Selector.MatchLabels[machinelearningv1.Label_seldon_app] = pSvcName
deploy.Spec.Template.ObjectMeta.Labels[machinelearningv1.Label_seldon_app] = pSvcName
port := int(svc.Spec.Ports[0].Port)
if svc.Spec.Ports[0].Name == "grpc" {
httpAllowed = false
externalPorts[i] = httpGrpcPorts{httpPort: 0, grpcPort: port}
psvc, err := createPredictorService(pSvcName, seldonId, &p, mlDep, 0, port, "", log)
if err != nil {
return nil, err
}
c.services = append(c.services, psvc)
c.serviceDetails[pSvcName] = &machinelearningv1.ServiceStatus{
SvcName: pSvcName,
GrpcEndpoint: pSvcName + "." + namespace + ":" + strconv.Itoa(port),
}
} else {
externalPorts[i] = httpGrpcPorts{httpPort: port, grpcPort: 0}
grpcAllowed = false
psvc, err := createPredictorService(pSvcName, seldonId, &p, mlDep, port, 0, "", log)
if err != nil {
return nil, err
}
c.services = append(c.services, psvc)
c.serviceDetails[pSvcName] = &machinelearningv1.ServiceStatus{
SvcName: pSvcName,
HttpEndpoint: pSvcName + "." + namespace + ":" + strconv.Itoa(port),
}
}
}
}
}
c.deployments = append(c.deployments, deploy)
}
err = createStandaloneModelServers(r, mlDep, &p, &c, p.Graph)
if err != nil {
return nil, err
}
if !noEngine {
// Add service orchestrator to engine deployment if needed
if !hasSeparateEnginePod {
var deploy *appsv1.Deployment
found := false
// find the pu that the webhook marked as localhost as its corresponding deployment should get the engine
pu := machinelearningv1.GetEnginePredictiveUnit(p.Graph)
if pu == nil {
// below should never happen - if it did would suggest problem in webhook
return nil, fmt.Errorf("Engine not separate and no pu with localhost service - not clear where to inject engine")
}
// find the deployment with a container for the pu marked for engine
for i, _ := range c.deployments {
dep := c.deployments[i]
for _, con := range dep.Spec.Template.Spec.Containers {
if strings.Compare(con.Name, pu.Name) == 0 {
deploy = dep
found = true
}
}
}
if !found {
// by this point we should have created the Deployment corresponding to the pu marked localhost - if we haven't something has gone wrong
return nil, fmt.Errorf("Engine not separate and no deployment for pu with localhost service - not clear where to inject engine")
}
err := addEngineToDeployment(mlDep, &p, engine_http_port, engine_grpc_port, pSvcName, deploy)
if err != nil {
return nil, err
}
}
//Create Service for Predictor - exposed externally (ambassador or istio) and points at engine
httpPort := engine_http_port
if httpAllowed == false {
httpPort = 0
}
grpcPort := engine_grpc_port
if grpcAllowed == false {
grpcPort = 0
}
psvc, err := createPredictorService(pSvcName, seldonId, &p, mlDep, httpPort, grpcPort, "", log)
if err != nil {
return nil, err
}
c.services = append(c.services, psvc)
if httpAllowed && grpcAllowed {
c.serviceDetails[pSvcName] = &machinelearningv1.ServiceStatus{
SvcName: pSvcName,
HttpEndpoint: pSvcName + "." + namespace + ":" + strconv.Itoa(engine_http_port),
GrpcEndpoint: pSvcName + "." + namespace + ":" + strconv.Itoa(engine_grpc_port),
}
} else if httpAllowed {
c.serviceDetails[pSvcName] = &machinelearningv1.ServiceStatus{
SvcName: pSvcName,
HttpEndpoint: pSvcName + "." + namespace + ":" + strconv.Itoa(engine_http_port),
}
} else if grpcAllowed {
c.serviceDetails[pSvcName] = &machinelearningv1.ServiceStatus{
SvcName: pSvcName,
GrpcEndpoint: pSvcName + "." + namespace + ":" + strconv.Itoa(engine_grpc_port),
}
}
externalPorts[i] = httpGrpcPorts{httpPort: httpPort, grpcPort: grpcPort}
}
err = createExplainer(r, mlDep, &p, &c, pSvcName, log)
if err != nil {
return nil, err
}
}
//TODO Fixme - not changed to handle per predictor scenario
if GetEnv(ENV_ISTIO_ENABLED, "false") == "true" {
vsvcs, dstRule, err := createIstioResources(mlDep, seldonId, namespace, externalPorts, httpAllowed, grpcAllowed)
if err != nil {
return nil, err
}
c.virtualServices = append(c.virtualServices, vsvcs...)
c.destinationRules = append(c.destinationRules, dstRule...)
}
return &c, nil
}
//Creates Service for Predictor - exposed externally (ambassador or istio)
func createPredictorService(pSvcName string, seldonId string, p *machinelearningv1.PredictorSpec,
mlDep *machinelearningv1.SeldonDeployment,
engine_http_port int,
engine_grpc_port int,
ambassadorNameOverride string,
log logr.Logger) (pSvc *corev1.Service, err error) {
namespace := getNamespace(mlDep)
psvc := &corev1.Service{
ObjectMeta: metav1.ObjectMeta{
Name: pSvcName,
Namespace: namespace,
Labels: map[string]string{machinelearningv1.Label_seldon_app: pSvcName,
machinelearningv1.Label_seldon_id: seldonId},
},
Spec: corev1.ServiceSpec{
Selector: map[string]string{machinelearningv1.Label_seldon_app: pSvcName},
SessionAffinity: corev1.ServiceAffinityNone,
Type: corev1.ServiceTypeClusterIP,
},
}
if engine_http_port != 0 && len(psvc.Spec.Ports) == 0 {
psvc.Spec.Ports = append(psvc.Spec.Ports, corev1.ServicePort{Protocol: corev1.ProtocolTCP, Port: int32(engine_http_port), TargetPort: intstr.FromInt(engine_http_port), Name: "http"})
}
if engine_grpc_port != 0 && len(psvc.Spec.Ports) < 2 {
psvc.Spec.Ports = append(psvc.Spec.Ports, corev1.ServicePort{Protocol: corev1.ProtocolTCP, Port: int32(engine_grpc_port), TargetPort: intstr.FromInt(engine_grpc_port), Name: "grpc"})
}
if GetEnv("AMBASSADOR_ENABLED", "false") == "true" {
psvc.Annotations = make(map[string]string)
//Create top level Service
ambassadorConfig, err := getAmbassadorConfigs(mlDep, p, pSvcName, engine_http_port, engine_grpc_port, ambassadorNameOverride)
if err != nil {
return nil, err
}
psvc.Annotations[AMBASSADOR_ANNOTATION] = ambassadorConfig
}
if getAnnotation(mlDep, machinelearningv1.ANNOTATION_HEADLESS_SVC, "false") != "false" {
log.Info("Creating Headless SVC")
psvc.Spec.ClusterIP = "None"
}
return psvc, err
}
// service for hitting a model directly, not via engine - not exposed externally, also adds probes
func createContainerService(deploy *appsv1.Deployment, p machinelearningv1.PredictorSpec, mlDep *machinelearningv1.SeldonDeployment, con *corev1.Container, c components) *corev1.Service {
//containerServiceKey := machinelearningv1.GetPredictorServiceNameKey(con)
containerServiceKey := machinelearningv1.Label_seldon_app_svc
containerServiceValue := machinelearningv1.GetContainerServiceName(mlDep.Name, p, con)
pu := machinelearningv1.GetPredictiveUnit(p.Graph, con.Name)
// only create services for containers defined as pus in the graph
if pu == nil {
return nil
}
namespace := getNamespace(mlDep)
portType := "http"
if pu.Endpoint.Type == machinelearningv1.GRPC {
portType = "grpc"
}
var portNum int32
portNum = 0
existingPort := machinelearningv1.GetPort(portType, con.Ports)
if existingPort != nil {
portNum = existingPort.ContainerPort
}
// pu should have a port set by seldondeployment_create_update_handler.go (if not by user)
// that mutator modifies SeldonDeployment and fires before this controller
if pu.Endpoint.ServicePort != 0 {
portNum = pu.Endpoint.ServicePort
}
if portNum == 0 {
// should have port by now
// if we don't know what it would respond to so can't create a service for it
return nil
}
if portType == "grpc" {
c.serviceDetails[containerServiceValue] = &machinelearningv1.ServiceStatus{
SvcName: containerServiceValue,
GrpcEndpoint: containerServiceValue + "." + namespace + ":" + strconv.Itoa(int(portNum))}
} else {
c.serviceDetails[containerServiceValue] = &machinelearningv1.ServiceStatus{
SvcName: containerServiceValue,
HttpEndpoint: containerServiceValue + "." + namespace + ":" + strconv.Itoa(int(portNum))}
}
svc := &corev1.Service{
ObjectMeta: metav1.ObjectMeta{
Name: containerServiceValue,
Namespace: namespace,
Labels: map[string]string{containerServiceKey: containerServiceValue, machinelearningv1.Label_seldon_id: mlDep.Name},
},
Spec: corev1.ServiceSpec{
Ports: []corev1.ServicePort{
{
Protocol: corev1.ProtocolTCP,
Port: portNum,
TargetPort: intstr.FromInt(int(portNum)),
Name: portType,
},
},
Type: corev1.ServiceTypeClusterIP,
Selector: map[string]string{containerServiceKey: containerServiceValue},
SessionAffinity: corev1.ServiceAffinityNone,
},
}
//Add labels for this service to deployment
deploy.ObjectMeta.Labels[containerServiceKey] = containerServiceValue
deploy.Spec.Selector.MatchLabels[containerServiceKey] = containerServiceValue
deploy.Spec.Template.ObjectMeta.Labels[containerServiceKey] = containerServiceValue
if existingPort == nil || con.Ports == nil {
con.Ports = append(con.Ports, corev1.ContainerPort{Name: portType, ContainerPort: portNum, Protocol: corev1.ProtocolTCP})
}
if con.LivenessProbe == nil {
con.LivenessProbe = &corev1.Probe{Handler: corev1.Handler{TCPSocket: &corev1.TCPSocketAction{Port: intstr.FromString(portType)}}, InitialDelaySeconds: 60, PeriodSeconds: 5, SuccessThreshold: 1, FailureThreshold: 3, TimeoutSeconds: 1}
}
if con.ReadinessProbe == nil {
con.ReadinessProbe = &corev1.Probe{Handler: corev1.Handler{TCPSocket: &corev1.TCPSocketAction{Port: intstr.FromString(portType)}}, InitialDelaySeconds: 20, PeriodSeconds: 5, SuccessThreshold: 1, FailureThreshold: 3, TimeoutSeconds: 1}
}
// Add livecycle probe
if con.Lifecycle == nil {
con.Lifecycle = &corev1.Lifecycle{PreStop: &corev1.Handler{Exec: &corev1.ExecAction{Command: []string{"/bin/sh", "-c", "/bin/sleep 10"}}}}
}
// Add Environment Variables
if !utils.HasEnvVar(con.Env, machinelearningv1.ENV_PREDICTIVE_UNIT_SERVICE_PORT) {
con.Env = append(con.Env, corev1.EnvVar{Name: machinelearningv1.ENV_PREDICTIVE_UNIT_SERVICE_PORT, Value: strconv.Itoa(int(portNum))})
}
if pu != nil && len(pu.Parameters) > 0 {
if !utils.HasEnvVar(con.Env, machinelearningv1.ENV_PREDICTIVE_UNIT_PARAMETERS) {
con.Env = append(con.Env, corev1.EnvVar{Name: machinelearningv1.ENV_PREDICTIVE_UNIT_PARAMETERS, Value: utils.GetPredictiveUnitAsJson(pu.Parameters)})
}
}
// Always set the predictive and deployment identifiers
con.Env = append(con.Env, []corev1.EnvVar{
corev1.EnvVar{Name: machinelearningv1.ENV_PREDICTIVE_UNIT_ID, Value: con.Name},
corev1.EnvVar{Name: machinelearningv1.ENV_PREDICTOR_ID, Value: p.Name},
corev1.EnvVar{Name: machinelearningv1.ENV_SELDON_DEPLOYMENT_ID, Value: mlDep.ObjectMeta.Name},
}...)
return svc
}
func createDeploymentWithoutEngine(depName string, seldonId string, seldonPodSpec *machinelearningv1.SeldonPodSpec, p *machinelearningv1.PredictorSpec, mlDep *machinelearningv1.SeldonDeployment) *appsv1.Deployment {
deploy := &appsv1.Deployment{
ObjectMeta: metav1.ObjectMeta{
Name: depName,
Namespace: getNamespace(mlDep),
Labels: map[string]string{machinelearningv1.Label_seldon_id: seldonId, "app": depName, "fluentd": "true"},
},
Spec: appsv1.DeploymentSpec{
Selector: &metav1.LabelSelector{
MatchLabels: map[string]string{machinelearningv1.Label_seldon_id: seldonId},
},
Template: corev1.PodTemplateSpec{
ObjectMeta: metav1.ObjectMeta{
Labels: map[string]string{machinelearningv1.Label_seldon_id: seldonId, "app": depName, "fluentd": "true"},
Annotations: mlDep.Spec.Annotations,
},
},
Strategy: appsv1.DeploymentStrategy{RollingUpdate: &appsv1.RollingUpdateDeployment{MaxUnavailable: &intstr.IntOrString{StrVal: "10%"}}},
},
}
if p.Shadow == true {
deploy.Spec.Template.ObjectMeta.Labels["shadow"] = "true"
}
if seldonPodSpec != nil {
deploy.Spec.Template.Spec = seldonPodSpec.Spec
// add more annotations
for k, v := range seldonPodSpec.Metadata.Annotations {
deploy.Spec.Template.ObjectMeta.Annotations[k] = v
}
}
// add predictor labels
for k, v := range p.Labels {
deploy.ObjectMeta.Labels[k] = v
deploy.Spec.Template.ObjectMeta.Labels[k] = v
}
//Add some default to help with diffs in controller
if deploy.Spec.Template.Spec.RestartPolicy == "" {
deploy.Spec.Template.Spec.RestartPolicy = corev1.RestartPolicyAlways
}
if deploy.Spec.Template.Spec.DNSPolicy == "" {
deploy.Spec.Template.Spec.DNSPolicy = corev1.DNSClusterFirst
}
if deploy.Spec.Template.Spec.SchedulerName == "" {
deploy.Spec.Template.Spec.SchedulerName = "default-scheduler"
}
if deploy.Spec.Template.Spec.SecurityContext == nil {
deploy.Spec.Template.Spec.SecurityContext = &corev1.PodSecurityContext{}
}
var terminationGracePeriod int64 = 20
deploy.Spec.Template.Spec.TerminationGracePeriodSeconds = &terminationGracePeriod
volFound := false
for _, vol := range deploy.Spec.Template.Spec.Volumes {
if vol.Name == machinelearningv1.PODINFO_VOLUME_NAME {
volFound = true
}
}
if !volFound {
var defaultMode = corev1.DownwardAPIVolumeSourceDefaultMode
//Add downwardAPI
deploy.Spec.Template.Spec.Volumes = append(deploy.Spec.Template.Spec.Volumes, corev1.Volume{Name: machinelearningv1.PODINFO_VOLUME_NAME, VolumeSource: corev1.VolumeSource{
DownwardAPI: &corev1.DownwardAPIVolumeSource{Items: []corev1.DownwardAPIVolumeFile{
{Path: "annotations", FieldRef: &corev1.ObjectFieldSelector{FieldPath: "metadata.annotations", APIVersion: "v1"}}}, DefaultMode: &defaultMode}}})
}
return deploy
}
func getPort(name string, ports []corev1.ContainerPort) *corev1.ContainerPort {
for i := 0; i < len(ports); i++ {
if ports[i].Name == name {
return &ports[i]
}
}
return nil
}
// Create Services specified in components.
func createIstioServices(r *SeldonDeploymentReconciler, components *components, instance *machinelearningv1.SeldonDeployment, log logr.Logger) (bool, error) {
ready := true
for _, svc := range components.virtualServices {
if err := controllerutil.SetControllerReference(instance, svc, r.Scheme); err != nil {
return ready, err
}
found := &istio.VirtualService{}
err := r.Get(context.TODO(), types.NamespacedName{Name: svc.Name, Namespace: svc.Namespace}, found)
if err != nil && errors.IsNotFound(err) {
ready = false
log.Info("Creating Virtual Service", "namespace", svc.Namespace, "name", svc.Name)
err = r.Create(context.TODO(), svc)
if err != nil {
return ready, err
}
} else if err != nil {
return ready, err
} else {
// Update the found object and write the result back if there are any changes
if !equality.Semantic.DeepEqual(svc.Spec, found.Spec) {
desiredSvc := found.DeepCopy()
found.Spec = svc.Spec
log.Info("Updating Virtual Service", "namespace", svc.Namespace, "name", svc.Name)
err = r.Update(context.TODO(), found)
if err != nil {
return ready, err
}
// Check if what came back from server modulo the defaults applied by k8s is the same or not
if !equality.Semantic.DeepEqual(desiredSvc.Spec, found.Spec) {
ready = false
//For debugging we will show the difference
diff, err := kmp.SafeDiff(desiredSvc.Spec, found.Spec)
if err != nil {
log.Error(err, "Failed to diff")
} else {
log.Info(fmt.Sprintf("Difference in VSVC: %v", diff))
}
} else {
log.Info("The VSVC are the same - api server defaults ignored")
}
} else {
log.Info("Found identical Virtual Service", "namespace", found.Namespace, "name", found.Name)
if instance.Status.ServiceStatus == nil {
instance.Status.ServiceStatus = map[string]machinelearningv1.ServiceStatus{}
}
/*
if _, ok := instance.Status.ServiceStatus[found.Name]; !ok {
instance.Status.ServiceStatus[found.Name] = *components.serviceDetails[found.Spec.HTTP[0].Route[0].Destination.Host]
err = r.Status().Update(context.Background(), instance)
if err != nil {
return ready, err
}
}
*/
}
}
}
for _, drule := range components.destinationRules {
if err := controllerutil.SetControllerReference(instance, drule, r.Scheme); err != nil {
return ready, err
}
found := &istio.DestinationRule{}
err := r.Get(context.TODO(), types.NamespacedName{Name: drule.Name, Namespace: drule.Namespace}, found)
if err != nil && errors.IsNotFound(err) {
ready = false
log.Info("Creating Istio Destination Rule", "namespace", drule.Namespace, "name", drule.Name)
err = r.Create(context.TODO(), drule)
if err != nil {
return ready, err
}
} else if err != nil {
return ready, err
} else {
// Update the found object and write the result back if there are any changes
if !equality.Semantic.DeepEqual(drule.Spec, found.Spec) {
desiredDrule := found.DeepCopy()
found.Spec = drule.Spec
log.Info("Updating Istio Destination Rule", "namespace", drule.Namespace, "name", drule.Name)
err = r.Update(context.TODO(), found)
if err != nil {
return ready, err
}
// Check if what came back from server modulo the defaults applied by k8s is the same or not
if !equality.Semantic.DeepEqual(desiredDrule.Spec, found.Spec) {
ready = false
//For debugging we will show the difference
diff, err := kmp.SafeDiff(desiredDrule.Spec, found.Spec)
if err != nil {
log.Error(err, "Failed to diff")
} else {
log.Info(fmt.Sprintf("Difference in Destination Rules: %v", diff))
}
} else {
log.Info("The Destination Rules are the same - api server defaults ignored")
}
} else {
log.Info("Found identical Istio Destination Rule", "namespace", found.Namespace, "name", found.Name)
if instance.Status.ServiceStatus == nil {
instance.Status.ServiceStatus = map[string]machinelearningv1.ServiceStatus{}
}
if _, ok := instance.Status.ServiceStatus[found.Name]; !ok {
instance.Status.ServiceStatus[found.Name] = *components.serviceDetails[found.Name]
err = r.Status().Update(context.Background(), instance)
if err != nil {
return ready, err
}
}
}
}
}
return ready, nil
}
// Create Services specified in components.
func createServices(r *SeldonDeploymentReconciler, components *components, instance *machinelearningv1.SeldonDeployment, all bool, log logr.Logger) (bool, error) {
ready := true
for _, svc := range components.services {
if !all {
if _, ok := svc.Annotations[AMBASSADOR_ANNOTATION]; ok {
log.Info("Skipping Ambassador Svc", "all", all, "namespace", svc.Namespace, "name", svc.Name)
continue
}
}
if err := ctrl.SetControllerReference(instance, svc, r.Scheme); err != nil {
return ready, err
}
found := &corev1.Service{}
err := r.Get(context.TODO(), types.NamespacedName{Name: svc.Name, Namespace: svc.Namespace}, found)
if err != nil && errors.IsNotFound(err) {
ready = false
log.Info("Creating Service", "all", all, "namespace", svc.Namespace, "name", svc.Name)
err = r.Create(context.TODO(), svc)
if err != nil {
return ready, err
}
} else if err != nil {
return ready, err
} else {
svc.Spec.ClusterIP = found.Spec.ClusterIP
// Update the found object and write the result back if there are any changes
if !equality.Semantic.DeepEqual(svc.Spec, found.Spec) || !equality.Semantic.DeepEqual(svc.Annotations, found.Annotations) {
desiredSvc := found.DeepCopy()
desiredSvc.Annotations = svc.Annotations
found.Spec = svc.Spec
found.Annotations = svc.Annotations
log.Info("Updating Service", "all", all, "namespace", svc.Namespace, "name", svc.Name)
err = r.Update(context.TODO(), found)
if err != nil {
return ready, err
}
// Check if what came back from server modulo the defaults applied by k8s is the same or not
if !equality.Semantic.DeepEqual(desiredSvc.Spec, found.Spec) {
ready = false
//For debugging we will show the difference
diff, err := kmp.SafeDiff(desiredSvc, found)
if err != nil {
log.Error(err, "Failed to diff")
} else {
log.Info(fmt.Sprintf("Difference in SVCs: %v", diff))
}
} else {
log.Info("The SVCs are the same - api server defaults ignored")
}
} else {
log.Info("Found identical Service", "all", all, "namespace", found.Namespace, "name", found.Name, "status", found.Status)
if instance.Status.ServiceStatus == nil {
instance.Status.ServiceStatus = map[string]machinelearningv1.ServiceStatus{}
}
if _, ok := instance.Status.ServiceStatus[found.Name]; !ok {
instance.Status.ServiceStatus[found.Name] = *components.serviceDetails[found.Name]
err = r.Status().Update(context.Background(), instance)
if err != nil {
return ready, err