fix: remove scale logic in getBoundingClientRect #1380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with elements of non-integer sizes (#1351 (comment))
The logic for the
scaleX
/scaleY
is faulty as explained in the comment, I can't quickly think of a solution but positioning is broken for all elements that aren't an integer of width or height. I think it takes priority over the scaling based on the issues I've been receiving for Tippy