fix: Use correct window to get the devicePixelRatio #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `roundOffsetsByDPR` utility was using the global window keyword instead of the `getWindow` utility. This meant that applications that render to childe windows would have blurry poppers sincee the device pixel ratio being used wouldn't be correct.Two cases where that could happen: * Parent window in another monitor * Parent window has a different zoom than the child window
Change Log for @popperjs/core (2.11.6 → 2.11.7)Bug Fixes
|
FezVrasta
approved these changes
Mar 14, 2023
|
@FezVrasta do you mind taking a look at the CI failures? I don't have enough understanding of the repo to know what action to take on those errors |
|
@FezVrasta @atomiks would you be able to help with the errors I'm seeing in the checks? 🙏🙏 |
|
It seems to be a problem with CI itself but I'm not sure what's going on to be fair. @atomiks may have some ideas? |
|
Don't know sorry, guess some packages/actions had some breaking changes not in semver or something :| |
|
I'll take care of it this week. |
scudette
added a commit
to Velocidex/velociraptor
that referenced
this pull request
Apr 18, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
@popperjs/core from 2.11.6 to 2.11.7.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **21 days ago**, on 2023-03-24.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@popperjs/core</b></summary>
<ul>
<li>
<b>2.11.7</b> - <a
href="https://snyk.io/redirect/github/floating-ui/floating-ui/releases/tag/v2.11.7">2023-03-24</a></br><h2>Bug
Fixes</h2>
<ul>
<li>fix: Use correct window to get the devicePixelRatio <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1623815836" data-permission-text="Title is private"
data-url="floating-ui/floating-ui#2229"
data-hovercard-type="pull_request"
data-hovercard-url="/floating-ui/floating-ui/pull/2229/hovercard"
href="https://snyk.io/redirect/github/floating-ui/floating-ui/pull/2229">#2229</a></li>
</ul>
</li>
<li>
<b>2.11.6</b> - 2022-08-11
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/popperjs/popper-core/releases">@popperjs/core
GitHub release notes</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI2MmQ5ZmZlNS0xMjVkLTQ4MWUtOGI4Ni04YTg1NzEzZTg4ZGIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjYyZDlmZmU1LTEyNWQtNDgxZS04Yjg2LThhODU3MTNlODhkYiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?pkg=@popperjs/core&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"62d9ffe5-125d-481e-8b86-8a85713e88db","prPublicId":"62d9ffe5-125d-481e-8b86-8a85713e88db","dependencies":[{"name":"@popperjs/core","from":"2.11.6","to":"2.11.7"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"76f4d127-566b-42ef-86f4-bdcbc92b90b4","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-03-24T13:51:24.971Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
roundOffsetsByDPRutility was using the global window keyword instead of thegetWindowutility. This meant that applications that render to child windows would have blurry poppers since the device pixel ratio being used wouldn't be correct. Two cases where that could happen: