Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use translate instead of translate3d #767

Closed
wants to merge 1 commit into from

Conversation

szhu
Copy link

@szhu szhu commented Apr 3, 2019

In some browsers like Chrome, using translate3d(x, y, 0) results in blurry text, while translate(x, y) doesn't.

@atomiks
Copy link
Collaborator

atomiks commented Apr 4, 2019

Have you tested the perf impact? I wonder if it matters much - if not, don't see why it can't be changed

@FezVrasta
Copy link
Member

I use translate3d for a performance reason. The 2d transformation is not as efficient

@FezVrasta FezVrasta closed this Apr 4, 2019
@atomiks
Copy link
Collaborator

atomiks commented Apr 4, 2019

@FezVrasta

I tested with 80 poppers translate vs translate3d while scrolling, there doesn't seem to be a noticeable difference tested via Performance DevTools. Both take up the same amount of rendering time. Doesn't will-change: transform provide the performance boost anyway?

@FezVrasta
Copy link
Member

Last time I ran my tests, translate3d gave a good performance boost, if you'd like to share your benchmark I can look deeper into it.

@szhu
Copy link
Author

szhu commented Apr 4, 2019

@FezVrasta I would like to run performance testing on this but I don't have a lot of background. Is there a performance test suite for popper.js, or what code did you use to figure out that translate3d was more performant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants