Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require SLiM version 4.0++ #1343

Open
petrelharp opened this issue Aug 29, 2022 · 2 comments
Open

require SLiM version 4.0++ #1343

petrelharp opened this issue Aug 29, 2022 · 2 comments
Milestone

Comments

@petrelharp
Copy link
Contributor

Over in MesserLab/SLiM#347 is described a bug leading to memory leaks and possible crashes in the case where reloading from a .trees file while there are Remembered individuals. We would only hit this if there historical samples and a condition on allele frequency. So, this just means we'll want to require SLiM version 4.01 (or whatever the next release that fixes this is).

It could also affect older sims, but as the conditioning code wasn't released, and we're only supporting SLiM v4 moving forward, we needn't worry about it.

@petrelharp
Copy link
Contributor Author

This needs to be changed in requirements/ and at https://github.com/popsim-consortium/stdpopsim/blob/main/stdpopsim/slim_engine.py#L1552

@nspope
Copy link
Collaborator

nspope commented Aug 29, 2022

There's also a hardcoded check here that could be updated:

# SLiM v3.6 sends `stop()` output to stderr, which we rely upon.
self._assert_min_version("3.6", slim_path)

edit Whoops you already mentioned that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants