Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iteration enhancement] we lose the filtration data of the iteration table, if we change tabs and go back again #221

Closed
servoz opened this issue Aug 18, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@servoz
Copy link
Contributor

servoz commented Aug 18, 2021

If we use the iteration table, as described in the document for the Via Input_Filter with the use of the iteration table mode :

Before initialisation:

If we change tabs (e.g. by going to the Data Browser or staying in the Pipeline Manager but opening a new editor or going to another editor and then coming back to the one with the pipeline to iterate) it seems that the data filter in the iteration table is lost.

For example:

  • I prepare an iteration as described in the documentation (exclusion of one patient out of the 3 in the database)
  • I go to the Data Browser then I come back in the Pipeline Manager to the editor with the iteration:
    • in this case there is no more filtration on the patients.
    • Same observation, staying in the piepline manager, if I change of editor and then go back.

The remedy is to redefine the filter each time we return to a tab, but we would like to be able to keep the data when we change tabs (and this is prone to errors).

@servoz servoz added the enhancement New feature or request label Aug 18, 2021
@LStruber
Copy link
Collaborator

In the same line, while the checkbox iterate pipeline is updated between tabs (if I open a tab with an iterated pipeline and another without, switching from one to the other automatically check or uncheck the box), it is not the case for the iteration table parameters.
In my opinion, they should also be "tab-dependent", as we could imagine to iterate over two different parameters in two different tabs.

@servoz
Copy link
Contributor Author

servoz commented Nov 16, 2021

I totally agree!

@LStruber LStruber self-assigned this Dec 7, 2021
@LStruber
Copy link
Collaborator

LStruber commented Dec 8, 2021

fix with commit 0665bf2

@LStruber LStruber closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants