-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to ES6 module #89
Comments
Because Node.JS ESM support is still experimental and using import/export means adding a build step, which break the 0 dependencies principle 😉 |
Actually @Minigugus, if you look back before 1.0 release in the commits I had the source in import/export syntax, and then a small script to convert to commonjs, hehe.. The reason I removed it was because I didn't want to spend more time setting up dual packages (it didn't seem set in stone then), and I also liked being able to just instantly test stuff out.. I think the time is better now, so I'd be fine digging the conversion script back out, convert and also help us in the progress of making Postgres.js deno compatible 😉 |
Awesome 😄 Maybe this can help https://github.com/Minigugus/postgres-deno 😏 😉 Also, if you are ready for ES6 modules, what about full TypeScript conversion (still Deno compatible 😉)? |
Nodejs 14 is LTS NOW, supports import/export and dual package loading. So, it’s time to migrate :) |
Any updates? |
@maxpain There's a PR now, you're welcome to try out I still need to test this for all supported node versions using both cjs and esm before I can merge.. |
why using module.exports whne you can import/export?
The text was updated successfully, but these errors were encountered: