Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Dismissible Tag optional icon #3321

Open
armingjazi opened this issue Jun 3, 2024 · 0 comments
Open

[FEATURE] - Dismissible Tag optional icon #3321

armingjazi opened this issue Jun 3, 2024 · 0 comments
Labels
community community request to be refined issue has to be refined

Comments

@armingjazi
Copy link

Portfolio

Employee

ART and Team

VMA - Customer Information App

Contact Details

a.ghajarjazi@reply.de

Problem

We are using Tags as filters. In this case, having the Dismissible Tag is the appropriate component. However, some of our filters also have icons. Tags can have icons, but Dismissible Tags do not.
I have attached our solution (having a component in the library will bring our design closer to Porsche Design)

image

Solution ideas and examples

Add an Icon Prop for the dismissible tag. If the team decides to pursue the idea, I am happy to provide a PR.

Business priority

Medium

Available assisting resources

Developer (1)

@armingjazi armingjazi added community community request to be refined issue has to be refined labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community request to be refined issue has to be refined
Projects
None yet
Development

No branches or pull requests

1 participant