Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Partials in React/Remix throws exception in React 19 #3341

Open
michaelworm opened this issue Jun 12, 2024 · 3 comments
Open

[BUG] - Partials in React/Remix throws exception in React 19 #3341

michaelworm opened this issue Jun 12, 2024 · 3 comments
Assignees
Labels
bug Something isn't working code community community request

Comments

@michaelworm
Copy link
Member

Contact Details

https://porschedev.slack.com/archives/CT7AVHTTQ/p1717755243690399

JS Framework

React/Remix

Porsche Design System version

latest

On which device(s) you can see the bug?

all

In which browsers you can see the bug?

No response

Browser version

No response

Reproduction Example

https://stackblitz.com/edit/remix-run-remix-yxdfzn?file=app%2Fpartials.server.tsx

Steps to reproduce the behavior

  1. Go to StackBlitz
  2. See error

Expected behavior

The page renders fine with React 19

Relevant log output

Error: Objects are not valid as a React child (found: object with keys {$$typeof, type, key, ref, props, _owner, _store}). If you meant to render a collection of children, use an array instead.
@michaelworm michaelworm added bug Something isn't working to be refined issue has to be refined community community request labels Jun 12, 2024
@michaelworm michaelworm self-assigned this Jun 12, 2024
@michaelworm michaelworm added code and removed to be refined issue has to be refined labels Jun 12, 2024
@kroofy
Copy link

kroofy commented Jun 12, 2024

It was introduced somewhere between these commits:
facebook/react@db913d8...cb15184

@kroofy
Copy link

kroofy commented Jun 12, 2024

The last working one: 19.0.0-canary-db913d8e17-20240422
The first failing one: 19.0.0-canary-cb151849e1-20240424

@michaelworm
Copy link
Member Author

michaelworm commented Jun 12, 2024

facebook/react@db913d8...cb15184#diff-126e377d76456bceb8f1f6c9a6668400f198ccb7bfc37b52083ac9fd4982c515

Bildschirmfoto 2024-06-12 um 16 15 15

This part looks interesting. The error we get is different but it looks like we need to use React 19 in our build too. Might be related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code community community request
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants