Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an annotation CsrfProtected #11

Open
tnodev opened this issue Jan 9, 2015 · 2 comments
Open

Create an annotation CsrfProtected #11

tnodev opened this issue Jan 9, 2015 · 2 comments

Comments

@tnodev
Copy link

tnodev commented Jan 9, 2015

Hello,

I'm using tapestry-csrf-protection since many months, and I log too much CsrfException which are not login attacks.

When using tapestry-csrf-protection, all the pages are under csrf protection, except page with annotation @NotCsrfProtected.
I will prefer that all the pages are NOT under csrf protection, except page with annotation @CsrfProtected. In my case, only the login page...

Thanks, Thomas

@derkoe
Copy link
Contributor

derkoe commented Jan 9, 2015

I think this would be not a good idea since the CSRF protection should be the default for a web framework (I think it should be even default in Tapestry Core).

Why wouldn't you protect all your pages (only login)?

@tnodev
Copy link
Author

tnodev commented Jan 10, 2015

Because I log with redmine all exceptions from 60 tapestry web sites.
They are a huge number of CsrfException from googleBot, bingbot, etc... These are not attack !

So I want to protect only my login page.
Except my login page, there is nothing to protect.

Protect or not all the page seems to me a good idea. It could be a configuration choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants