Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-authenticated ping endpoint to agent #29

Closed
olljanat opened this issue Oct 11, 2018 · 2 comments · Fixed by #32
Closed

Add non-authenticated ping endpoint to agent #29

olljanat opened this issue Oct 11, 2018 · 2 comments · Fixed by #32
Labels
enhancement New feature or request
Milestone

Comments

@olljanat
Copy link
Contributor

On multi swarm setup we want to be able have hardware load balancer between Portainer and Agent.
That way we can have example three manager nodes behind of that LB and make sure that Portainer is always contacting to working node.

Configuration it selves works already using SSL bridging but problem is that LB is not able to see if agent is really up or not. That why it would be nice to have simple non-authenticated /status endpoint on agent which can example just say OK so LB knows that as long it gets this response Agent is good to be used.

Then we don't loose access to Swarm from Portainer even if one node goes down.

@deviantony
Copy link
Member

deviantony commented Oct 11, 2018

@olljanat Please open your feature requests in our fronting repository for the whole Portainer ecosystem at https://github.com/portainer/portainer/issues

I think that someone already created one for this feature though: portainer/portainer#2288

IMO we can add a /ping endpoint just responding with a 200 that does not expect any authentication.

@deviantony deviantony added the enhancement New feature or request label Oct 11, 2018
@deviantony deviantony changed the title Add non-authenticated status endpoint to agent Add non-authenticated ping endpoint to agent Oct 17, 2018
@deviantony
Copy link
Member

@chiptus I think we can add the ping API endpoint and use it to tackle the agent api version handshake AND the problem raised in this issue.

API version is returned as a header as a part of all agent responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants