-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): missing browse volume option [EE-7179] #11901
base: develop
Are you sure you want to change the base?
fix(docker): missing browse volume option [EE-7179] #11901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why your fix is changing anything. why is AccessDatatable related?
Because I noticed that the codebase for |
@oscarzhou-portainer I don't see the added value. where we have it's because it used to be multiple values. but how does it fixes the issue? |
The main fix for the issue can be found https://github.com/portainer/portainer/pull/11901/files#diff-ee4ca3e2b0441ac5ba3be0fa63c816a8f7df3597efba58805fdeea6086cac77dL72-R74. The problem was that two extend table options were added to the VolumesDatatable, but they were not wrapped with the mergeOptions function. The reason why I suggest including In this code snippet, you can see that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could change extendTableOptions
to accept an array of extenders.
LGTM
a3c12d1
to
dfb2876
Compare
@oscarzhou-portainer you need to run |
closes EE-7179