Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portainer does not respect '--no-healthcheck' in Command for Node-Red container (but Docker itself does) #5101

Open
joefernwright opened this issue May 23, 2021 · 2 comments
Labels
bug/need-confirmation contributions-welcome This issue is not one our current roadmap, but we will help anyone that wants to work on it. kind/bug Applied to Bugs

Comments

@joefernwright
Copy link

joefernwright commented May 23, 2021

Bug description
Portainer does not respect '--no-healthcheck' option when running a Node-Red container. When I execute the following via SSH, the '--no-healthcheck' option works fine, the container gets listed in Portainer and runs without healtcheck (status "running")."

docker run -it -p 1880:1880 --no-healthcheck -v /srv/dev-disk-by-uuid-95f9376f-4b40-4f41-a85b-615712219901/data/nodered:/data --name node-red nodered/node-red

When the same container is stopped and re-started (via Portainer), the no-healthcheck is not respected any more and the container gets status "healthy", which means healtcheck is enabled.

I put '--no-healthcheck' into the field called Command (Override) in section "Command & logging". It does not matter if I create a new container or edit via "Duplicate/Edit".

So, in other words, when running a container via SSH and "docker run..." everything works as expected (healthcheck disabled) but if running the same container (or restarting) in Portainer, healthcheck is not getting disabled. This leads to a conclusion that Portainer manages somehow '--no-healthcheck' option wrong way.

I want to use '--no-healtcheck' option as Node-Red container has healtcheck enabled by default and it causes excessive logging (Syslog):
May 23 13:41:14 nebulonserver systemd[1]: run-docker-runtime\x2drunc-moby-00d4120caead6372631b47f1e0d98c2c0c138679fb21f63b15f930a60e58b4e3-runc.iPwfl5.mount: Succeeded. May 23 13:41:45 nebulonserver systemd[968]: run-docker-runtime\x2drunc-moby-00d4120caead6372631b47f1e0d98c2c0c138679fb21f63b15f930a60e58b4e3-runc.CBunCG.mount: Succeeded. May 23 13:41:45 nebulonserver systemd[1]: run-docker-runtime\x2drunc-moby-00d4120caead6372631b47f1e0d98c2c0c138679fb21f63b15f930a60e58b4e3-runc.CBunCG.mount: Succeeded. May 23 13:42:16 nebulonserver systemd[968]: run-docker-runtime\x2drunc-moby-00d4120caead6372631b47f1e0d98c2c0c138679fb21f63b15f930a60e58b4e3-runc.86GJsi.mount: Succeeded. May 23 13:42:46 nebulonserver systemd[968]: run-docker-runtime\x2drunc-moby-00d4120caead6372631b47f1e0d98c2c0c138679fb21f63b15f930a60e58b4e3-runc.c1IvKK.mount: Succeeded. May 23 13:43:17 nebulonserver systemd[968]: run-docker-runtime\x2drunc-moby-00d4120caead6372631b47f1e0d98c2c0c138679fb21f63b15f930a60e58b4e3-runc.YILx1f.mount: Succeeded. May 23 13:43:47 nebulonserver systemd[1]: run-docker-runtime\x2drunc-moby-00d4120caead6372631b47f1e0d98c2c0c138679fb21f63b15f930a60e58b4e3-runc.26eNHT.mount: Succeeded. May 23 13:43:47 nebulonserver systemd[968]: run-docker-runtime\x2drunc-moby-00d4120caead6372631b47f1e0d98c2c0c138679fb21f63b15f930a60e58b4e3-runc.26eNHT.mount: Succeeded.

Expected behavior
I would like Portainer to respect and add properly 'no-healthcheck' option to a run container.

Technical details:

  • Raspberry Pi 4 4GB
  • OMV 5.6.7.-1
  • Docker version 5:20.10.63-0debian-buster installed via OMV
  • Portainer 2.11 installed via OMV
  • Linux 5.10.17-v7I+ (Raspberry Pi OS - "2021-03-04-raspios-buster-armhf.zip")
@srebala
Copy link

srebala commented May 24, 2021

Hi
Command & logging is only variables passed to the containers, there is a feature request for the Healthcheck on services, please follow this
#827
However for standalone container , please raise a feature request and comment your request for container healthcheck support

@SvenDowideit SvenDowideit added the contributions-welcome This issue is not one our current roadmap, but we will help anyone that wants to work on it. label Sep 22, 2021
@SvenDowideit
Copy link
Contributor

I suspect this might not be complicated to implement - but will touch the entire UI->backend stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/need-confirmation contributions-welcome This issue is not one our current roadmap, but we will help anyone that wants to work on it. kind/bug Applied to Bugs
Projects
None yet
Development

No branches or pull requests

3 participants