Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfall Color Configuration by File on SD #779

Closed
AlphaGeek1 opened this issue Dec 30, 2022 · 4 comments
Closed

Waterfall Color Configuration by File on SD #779

AlphaGeek1 opened this issue Dec 30, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@AlphaGeek1
Copy link

AlphaGeek1 commented Dec 30, 2022

Request to configure waterfall color palette via file on SD card.
This is related to pull requests #744, #771, and #772, but mostly #744.

Deliver Mayhem with a file on the SD card something like default_palette,txt perhaps in the root directory, along with another directory named something like 'Waterfall_Palettes' and maybe include original, sunset, and rainbow.

Assuming there is already a routine in the code which opens and reads a text file containing key pairs, this could be used to read in the color palette data with minimal effect on limited memory from storing multiple palettes and additional UI code for selecting them.

This would give 3 options to users who just want to swap out the file for the existing palette of their choice, but also provide essentially limitless options to users who are inclined to edit the color palette file themselves.

@AlphaGeek1 AlphaGeek1 added the enhancement New feature or request label Dec 30, 2022
@AlphaGeek1
Copy link
Author

@Brumi-2021

@Brumi-2021
Copy link
Contributor

Brumi-2021 commented Jan 19, 2023

Hi @AlphaGeek1 ,
Probably you are right , I think that the best would be to revert that merged commit and come back to the previous Waterfall LUT colour scheme till someone can introduce a config LUT settings based on SD files.

Personally I like more the new one , but I have been trying to capture some AIS signals , and I am not used yet to calibrate my eyes with those colours a good S/N capture . If I adjust the LNA gain to have a clean signal with low background noise, then the replay does not work ... ( the S from S/N looks like too weak) .
Somehow I have not yet calibrated a correct S/N with those colours . Someone already comment that maybe the LUT is too linear colour change and not in dB's , I do not know , but maybe you are right and the easy correction for everybody would be to come back to the previous one .

Example those AIS captured with the new colour scheme , looks clean and good to my eyes, but when I tried to replay them it did not work . (they need to be captured with more GAIN )
image
image

FYI those are other stronger FM and AM signals comparison :
image
image

Cheers,

@AlphaGeek1
Copy link
Author

Agreed. Regardless of aesthetic preference, you have shown this is a usability issue at the moment.

@eried
Copy link
Member

eried commented Jan 4, 2024

Just closing this, since it ended being about preferences :)

@eried eried closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants