Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bond page graph - Add a way to get the historic price data for the graph @RusseII (collateralToken, convertibleToken) @RusseII #38

Closed
Tracked by #30
RusseII opened this issue Mar 28, 2022 · 6 comments · Fixed by #112
Closed
Tracked by #30

bond page graph - Add a way to get the historic price data for the graph @RusseII (collateralToken, convertibleToken) @RusseII #38

RusseII opened this issue Mar 28, 2022 · 6 comments · Fixed by #112
Milestone
Core Designs

Comments

@RusseII
Copy link
Contributor

RusseII commented Mar 28, 2022 •
edited
Loading

image

What data interval should be used to display the data on this graph?
@RusseII RusseII mentioned this issue Mar 28, 2022
Closed
4 tasks
@RusseII RusseII self-assigned this Mar 28, 2022
@RusseII RusseII added this to the Core Designs milestone Mar 28, 2022
@RusseII
Copy link
Contributor Author

RusseII commented Apr 13, 2022 •
edited
Loading

I think you can use coinGeko for this - https://www.coingecko.com/en/api/documentation

Use SWR and custom hook

You can look at the useTokenPrice hook for inspiration

@RusseII RusseII assigned Namaskar-1F64F and unassigned RusseII Apr 13, 2022
@luckyrobot
Copy link

luckyrobot commented Apr 13, 2022 •
edited
Loading

@Namaskar-1F64F note that this page does not exist yet, its what im working on currently (bond detail page) #30

edit: it exists now

2022-04-19 at 12 40 12

@luckyrobot luckyrobot changed the title Add a way to get the historic price data for the graph @RusseII (collateralToken, convertibleToken) @RusseII bond page graph - Add a way to get the historic price data for the graph @RusseII (collateralToken, convertibleToken) @RusseII Apr 19, 2022
@RusseII
Copy link
Contributor Author

RusseII commented Apr 19, 2022

@Namaskar-1F64F were you ever able to look into this?

@RusseII RusseII assigned RusseII and unassigned Namaskar-1F64F Apr 20, 2022
@RusseII RusseII linked a pull request Apr 20, 2022 that will close this issue
38 bond page graph add a way to get the historic price data for the graph russeii collateraltoken convertibletoken russeii #112
Merged
@luckyrobot luckyrobot reopened this Apr 20, 2022
@RusseII
Copy link
Contributor Author

RusseII commented Apr 20, 2022

@luckyrobot why did you re-open this? It was specifically for the functional part of getting the data

@luckyrobot
Copy link

luckyrobot commented Apr 20, 2022 •
edited
Loading

oh okay, do we have an issue for displaying the graph? i thought this issue was for both display and data

(opened caues i didnt think we did have 1)

@luckyrobot
Copy link

created #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Core Designs
3 participants
@Namaskar-1F64F @RusseII @luckyrobot