Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from react class based components to functional components. #5

Open
unckleg opened this issue Jul 20, 2020 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@unckleg
Copy link
Member

unckleg commented Jul 20, 2020

No description provided.

@unckleg unckleg added the enhancement New feature or request label Jul 20, 2020
@unckleg unckleg self-assigned this Jul 20, 2020
@blestab
Copy link

blestab commented Aug 12, 2020

Hi @unckleg may I help with this?

@unckleg
Copy link
Member Author

unckleg commented Aug 13, 2020

Hi @blestab thanks for initiative:
Here is the list of components that needs update from class based to rhooks:

  1. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Layout/Toast.tsx
  2. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Form/Footer.tsx
    3.https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Loader.tsx
  3. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Layout/Sidebar/SearchResults.tsx
  4. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Layout/Title.tsx
  5. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Modal/RemoveModal.tsx
  6. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/App.tsx
  7. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Form/ButtonBack.tsx
  8. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Layout/Sidebar/index.tsx
  9. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Home/Page/index.tsx
  10. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Auth/Page/Login/index.tsx
  11. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Form/DateTimeControlled.tsx
  12. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Form/DatepickerControlled.tsx
  13. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Form/ImageInput.tsx
  14. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Notification.tsx
  15. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/router.tsx
  16. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Layout/Sidebar/GlobalSidebar.tsx
  17. https://github.com/portfoolio/dashboard/blob/1caba64052dc63fde3fc46f409558e65c21a3327/src/modules/Core/Component/Layout/Module/Table/index.tsx

Feel free to create PR and pick any of those from the list, I'll do the rest in upcoming days.

Thanks!

@blestab
Copy link

blestab commented Aug 13, 2020

thanks @unckleg, i'll do my best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants