Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong URL to accept/decline moderated mails #449

Closed
schiessle opened this issue Jun 1, 2018 · 2 comments
Closed

Wrong URL to accept/decline moderated mails #449

schiessle opened this issue Jun 1, 2018 · 2 comments

Comments

@schiessle
Copy link

schiessle commented Jun 1, 2018

I run isso under https://mydomain.com/isso and everything works great, but the links send to me by mail to accept/decline comments look like this http://mydomain.com/id/..., correct would be https://mydomain.com/isso/id.... Is there a way to configure the root of isso so that the links for the moderation mails are constructed the right way? I couldn't find anything in the documentation.

@craigphicks
Copy link
Contributor

Change the line:

    uri = self.general_host + "/id/%i" % comment["id"]

to

    uri = local.host + "/id/%i" % comment["id"]

in isso/ext/notifications.py, or wait for a fixed version.

@blatinier
Copy link
Collaborator

You can now use the public-endpoint configuration in the [general] section of isso config. It should solve your problem.
(Newly merged in master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants