Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Werkzeug create a proper response string for CORS requests #359

Closed
wants to merge 1 commit into from
Closed

Conversation

hiliev
Copy link

@hiliev hiliev commented Nov 29, 2017

This fixes a Unicode issue in wsgi.py and resolves #297. It should also resolve #347.

Let Werkzeug produce a proper status string.
@SnorlaxYum
Copy link
Contributor

+1 for the pull request. Works fine under python 2.7 with isso, gevent and nginx.

@SnorlaxYum
Copy link
Contributor

The edits also works under python 3.5.3 with isso, gevent and nginx.
I'm wondering why this haven't been merged after one year and half...... That really helps for people who have followed the doc Advanced integration. @jelmer

add_cors_headers("200 Ok", [("Content-Type", "text/plain")])
return []
response = Response()
return response(environ, add_cors_headers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why this needs to be changed - the issue is the first argument to werkzeug.datastructures.Headers.

add_cors_headers("200 Ok", [("Content-Type", "text/plain")])
return []
response = Response()
return response(environ, add_cors_headers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why this needs to be changed - the issue is the first argument to werkzeug.datastructures.Headers.

@SnorlaxYum
Copy link
Contributor

Okay, just fixed it: #555 .

@ix5 ix5 added needs-decision Architectural/Behavioral decision by maintainers needed server (Python) server code labels Feb 6, 2022
@ix5
Copy link
Member

ix5 commented Apr 23, 2022

Is anyone still using uwsgi? Otherwise we might want to remove any reference of support for it.

Closing soon unless someone can provide more information.

@ix5
Copy link
Member

ix5 commented Apr 24, 2022

I forgot that I had already looked into this in #297 (comment)

Closing.

@ix5 ix5 closed this Apr 24, 2022
@ix5 ix5 removed the needs-decision Architectural/Behavioral decision by maintainers needed label Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server (Python) server code
Projects
None yet
4 participants