New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let Werkzeug create a proper response string for CORS requests #359
Conversation
+1 for the pull request. Works fine under python 2.7 with isso, gevent and nginx. |
The edits also works under python 3.5.3 with isso, gevent and nginx. |
add_cors_headers("200 Ok", [("Content-Type", "text/plain")]) | ||
return [] | ||
response = Response() | ||
return response(environ, add_cors_headers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why this needs to be changed - the issue is the first argument to werkzeug.datastructures.Headers.
add_cors_headers("200 Ok", [("Content-Type", "text/plain")]) | ||
return [] | ||
response = Response() | ||
return response(environ, add_cors_headers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why this needs to be changed - the issue is the first argument to werkzeug.datastructures.Headers.
Okay, just fixed it: #555 . |
Is anyone still using Closing soon unless someone can provide more information. |
I forgot that I had already looked into this in #297 (comment) Closing. |
This fixes a Unicode issue in
wsgi.py
and resolves #297. It should also resolve #347.