[server] Strip trailing slash from public-endpoint, disallow trailing slash #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix5
force-pushed
the
public-endpoint-trailing-slash
branch
from
da00646
to
defa429
Compare
ix5
force-pushed
the
public-endpoint-trailing-slash
branch
from
defa429
to
de07b3a
Compare
ix5
changed the title
ix5
force-pushed
the
public-endpoint-trailing-slash
branch
from
de07b3a
to
11876dd
Compare
Starting in 0.13, a trailing slash in `[server] public-endpoint` is now discouraged and throws a warning.
ix5
force-pushed
the
public-endpoint-trailing-slash
branch
from
11876dd
to
091b069
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rstbecause this is a user-facing change or an important bugfixisso: config: Strip trailing public-endpoint slash
Fixes #498
docs: server-conf: public-endpoint trailing '/' forbidden
Starting in 0.13, a trailing slash in
[server] public-endpointis now discouraged and throws a warning.tests: guard: Remove obsolete werkzeug 0.8 check
Other considerations
Ideally, we should strip the trailing slash automatically from any config value that contains a URL, and be consistent with examples in docs, example config files.