Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Add /config endpoint #880

Merged
merged 3 commits into from May 24, 2022
Merged

Conversation

ix5
Copy link
Member

@ix5 ix5 commented May 24, 2022

Checklist

  • All new and existing tests are passing
  • (If adding features:) I have added tests to cover my changes
  • (If docs changes needed:) I have updated the documentation accordingly.
  • I have added an entry to CHANGES.rst because this is a user-facing change or an important bugfix
  • I have written proper commit message(s)

What changes does this Pull Request introduce?

Add /config endpoint which returns the same data as the config object of the / GET endpoint. This endpoint is unused by the current client but useful for development and will be utilized in the future.

A partial re-send of #821

Why is this necessary?

This PR prepares work for fetching the configuration from a dedicated endpoint before fetching any comments or inserting a postbox. Instead of fixing all the issues that pop up in #821 immediately, merge this partial (currently unused) feature already and then start work on ironing out client bugs.

ix5 added 2 commits May 24, 2022 02:02
Useful for the client to avoid having to fetch a thread from
`/` just to get config options.
@ix5 ix5 added client (Javascript) client code and CSS feature labels May 24, 2022
@ix5 ix5 added this to the 0.13 milestone May 24, 2022
@ix5 ix5 merged commit 89024de into isso-comments:master May 24, 2022
@ix5 ix5 deleted the config-endpoint branch May 24, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client (Javascript) client code and CSS feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant