Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move py-shiny specific assets from www/shared/py-shiny to www/py-shiny #1497

Closed
gadenbuie opened this issue Jul 5, 2024 · 0 comments · Fixed by #1499
Closed

Move py-shiny specific assets from www/shared/py-shiny to www/py-shiny #1497

gadenbuie opened this issue Jul 5, 2024 · 0 comments · Fixed by #1499

Comments

@gadenbuie
Copy link
Collaborator

The data frame and chat UI work has added assets in www/shared/py-shiny, but the HTML dependency-updating script in scripts/htmlDependencies.R has always deleted and recreated this directory.

We could carve out an exception for www/shared/py-shiny or we could move the directory to www/shared. I'm in favor of the second option because we rely on deleting and recreating www/shared to also delete unneeded files during the upgrade.

cc @schloerke @cpsievert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Move www/shared/py-shiny to www/py-shiny posit-dev/py-shiny
1 participant
@gadenbuie