Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive on Sympy primitives and SupportsRealImag #4

Closed
posita opened this issue Nov 13, 2021 · 0 comments
Closed

False positive on Sympy primitives and SupportsRealImag #4

posita opened this issue Nov 13, 2021 · 0 comments

Comments

@posita
Copy link
Collaborator

posita commented Nov 13, 2021 •
edited

Sympy primitives register with the numeric tower, but they do not provide real or imag, but they do provide as_real_imag. Is there a way we can deal with that effectively (perhaps similarly to the numerator and denominator helper functions)?
@posita posita closed this as completed in bc031a7 Nov 14, 2021
posita added a commit that referenced this issue Nov 14, 2021
@posita
Split SupportsRealImag into SupportsRealImagProperties and ``…
1ebeea0 
…SupportsRealImagAsMethod``

Now ``sympy.core.numbers`` primitives are adequately supported (excepting general false positives; see #5).

Fixes #4.
posita added a commit that referenced this issue Nov 15, 2021
@posita
Create SupportsRealImagAsMethod, real, and imag
f107863 
Now ``sympy.core.numbers`` primitives are adequately supported (excepting general false positives; see #5).

Fixes #4.

Also renames ``SupportsNumeratorDenominatorProperties`` to ``SupportsNumeratorDenominator`` for consistency.
posita added a commit that referenced this issue Nov 15, 2021
@posita
Create SupportsRealImagAsMethod, real, and imag
667eb81 
Now ``sympy.core.numbers`` primitives are adequately supported (excepting general false positives; see #5).

Fixes #4.

Also renames ``SupportsNumeratorDenominatorProperties`` to ``SupportsNumeratorDenominator`` for consistency.
posita added a commit that referenced this issue Nov 15, 2021
@posita
Create SupportsRealImagAsMethod, real, and imag
daa7235 
Now ``sympy.core.numbers`` primitives are adequately supported (excepting general false positives; see #5).

Fixes #4.

Also renames ``SupportsNumeratorDenominatorProperties`` to ``SupportsNumeratorDenominator`` for consistency.
posita added a commit that referenced this issue Nov 15, 2021
@posita
Create SupportsRealImagAsMethod, real, and imag
0410d96 
Now ``sympy.core.numbers`` primitives are adequately supported (excepting general false positives; see #5).

Fixes #4.

Also renames ``SupportsNumeratorDenominatorProperties`` to ``SupportsNumeratorDenominator`` for consistency.
posita added a commit that referenced this issue Nov 15, 2021
@posita
Create SupportsRealImagAsMethod, real, and imag
4379ff6 
Now ``sympy.core.numbers`` primitives are adequately supported (excepting general false positives; see #5).

Fixes #4.

Also renames ``SupportsNumeratorDenominatorProperties`` to ``SupportsNumeratorDenominator`` for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@posita