-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review: Batch of 10 functions from linalg ready for review #40
Comments
(I'm going to have a conversation with myself to demonstrate what might happen when you ask for a review. Many times I'll just make change directly so we can pass this along to Numpy). Remember to specify that you built numpy and the docs, and then ran the doctests after installing numpy.
Everything built, so hooray! Remember to specific so I know it's working before I make changes. Comments:
|
The changes all built. I've pushed them. Here's are two branches:
@charris, I'd love your feedback. Here's some questions I have:
We can run this AI tool across all of the Numpy code base. Some times AI will say a function has sufficient examples. Sometimes it returns utter garbage. Other times it finds nice extra examples. Often, it does a decent job of extending the existing examples.
I don't want to overload the PR list (we're around 200, and I know you guys want to keep it to 150). That's why batching may be better.
Thanks for being willing to be voluntold by @teoliphant to help us out here. |
I'm closing this issue. It as designed as a practice run. I've gotten the needed feedback from the NumPy maintainers at the triage meetings. |
Please review the examples in the following branch
Close when the following are complete:
The text was updated successfully, but these errors were encountered: