Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The mod isn't actually disabling itself when Kerbalism is installed #88

Closed
siimav opened this issue Jun 21, 2023 · 1 comment
Closed

The mod isn't actually disabling itself when Kerbalism is installed #88

siimav opened this issue Jun 21, 2023 · 1 comment
Labels
testing

Comments

@siimav
Copy link

siimav commented Jun 21, 2023

DynamicBatteryStorage/Source/DynamicBatteryStorage/DynamicBatteryStorage.cs

Lines 52 to 56 in 402ab6f

protected override void OnAwake()
{
base.OnAwake();
enabled = Settings.Enabled;
}

VesselModule.enabled will get overwritten every Update with the value from VesselModule.ShouldBeActive(). So FixedUpdate will still run and cause issues.

Relates to #48 and #53
@siimav siimav mentioned this issue Jun 22, 2023
Merged
@ChrisAdderley
Copy link
Collaborator

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siimav @ChrisAdderley