Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the result #12

Closed
Wangld5 opened this issue Sep 15, 2021 · 2 comments
Closed

About the result #12

Wangld5 opened this issue Sep 15, 2021 · 2 comments

Comments

@Wangld5
Copy link

Wangld5 commented Sep 15, 2021

image
I test the model in dress dataset, and get the result above. The results do not match the paper and I run it following the command you write. Do you know why ?

@numpee
Copy link
Collaborator

numpee commented Sep 15, 2021

Hi,
Please refer to the "Notes on Evaluation" part of the README: https://github.com/postBG/CosMo.pytorch#warning-notes-on-evaluation
Also another user pointed out that some papers concatenate all three training subsets, then evaluate on each subset separately. Doing so will actually lead to better performances than what we reported in our paper.

@Wangld5
Copy link
Author

Wangld5 commented Sep 16, 2021

Thanks, I will try to uncomment the code presented in fashionIQ.py.

@numpee numpee closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants