feat: add types #155
feat: add types #155
Conversation
ludofischer
force-pushed
the
typescript
branch
from
1e18e35
to
c81442b
Compare
src/lib/reducer.js
Outdated
| isValueType(item.node.type) && item.node.value === 0); | ||
| withoutZeroItem.unshift(firstZeroItem) | ||
| isValueType(item.node) && item.node.value === 0); | ||
| withoutZeroItem.unshift(/** @type Collectible*/(firstZeroItem)) |
There was a problem hiding this comment.
Potential bug? I don't see why firstZeroItem could not be undefined. Without this case TypeScript complains every time you get an element out of collected.
There was a problem hiding this comment.
hm, but firstZeroItem can be undefined, we should add check firstNonZeroItem && firstNonZeroItem.preOperator === '-', but it is regarding how ts do checks, because logic is fine here
There was a problem hiding this comment.
I've replaced the cast with checking if firstZeroItem is truthy before unshifting it. It makes no sense no add an undefined or null item to the array anyway.
| @@ -70,8 +88,11 @@ export default (node, property, options, result) => { | |||
| ? transformSelector(node[property], options, result, node) | |||
| : transformValue(node[property], options, result, node); | |||
| } catch (error) { | |||
| result.warn(error.message, { node }); | |||
|
|
|||
| if (error instanceof Error) { | |||
There was a problem hiding this comment.
Is there a way to avoid this?
There was a problem hiding this comment.
Using as//** @type {Error} **/ (error)
ludofischer
force-pushed
the
typescript
branch
from
c81442b
to
30ab635
Compare
|
I've added |
No description provided.