Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing #123

Closed
RyanZim opened this issue Apr 29, 2017 · 6 comments
Closed

Tests are failing #123

RyanZim opened this issue Apr 29, 2017 · 6 comments

Comments

@RyanZim
Copy link
Collaborator

RyanZim commented Apr 29, 2017

  1 test failed [21:00:18]



  error › invalid --config
  /home/ryan/postcss-cli/test/error.js:44

   43:   .then(({ err, code }) => {                         
   44:     t.is(code, 1, 'expected non-zero error code')    
   45:     t.regex(err, /ENOENT: no such file or directory/)

  Actual:

    0

  Expected:

    1

  expected non-zero error code

Attn: @michael-ciniawsky

I suspect this has something to do with the latest patch version of cosmiconfig, will investigate later if no one else beats me to it.

@michael-ciniawsky
Copy link
Contributor

This error /ENOENT: no such file or directory/ was removed with the latest cosmiconfig update

cosmiconfig/cosmiconfig#63
cosmiconfig/cosmiconfig#64

@RyanZim
Copy link
Collaborator Author

RyanZim commented Apr 29, 2017

OK, thanks for doing the lookup!

It seems that we should still error out somehow if the config fails to load.

@michael-ciniawsky
Copy link
Contributor

Yep, but I don't now how yet tbh 😛 Now they shifted the responsibility for all their crap on us again, suckers.... 😛 I also need to add something like resolve-from to postcss-load-config, because currently, if the CLI is installed globally it fails atm, (it doesn't require() the plugins from process.cwd()) I fix it soon when time :)

@RyanZim
Copy link
Collaborator Author

RyanZim commented Apr 29, 2017

I also need to add something like resolve-from to postcss-load-config, because currently, if the CLI is installed globally it fails atm, (it doesn't require() the plugins from process.cwd()) I fix it soon when time :)

Ugh; that's why it's good to use devDependencies + npm scripts

@michael-ciniawsky
Copy link
Contributor

Yep I also prefer it that way, but the fix is easy and it's nothing urgent 😛

@RyanZim
Copy link
Collaborator Author

RyanZim commented Feb 10, 2018

@michael-ciniawsky Is this worth fixing, or do we just remove that test and leave things as they are?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants