Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Resolve variables in media queries #24

Closed
hgl opened this issue Apr 4, 2015 · 9 comments
Closed

Resolve variables in media queries #24

hgl opened this issue Apr 4, 2015 · 9 comments

Comments

@hgl
Copy link

hgl commented Apr 4, 2015

As mentioned in https://gist.github.com/hgl/77f0141eea04817ee0af

I would like to make this plugin also resolve variables used in media queries (including custom media queries).

But I need your opinion on the breaking change to the preserve property I proposed in that gist (tl;dr enabling it doesn't fallback to specified values for resolvable values).

@MoOx
Copy link
Contributor

MoOx commented Apr 4, 2015

This is invalid according to custom props specs so I won't add that into this module. I will close this issue when I will add a note about that in the Readme.

@hgl
Copy link
Author

hgl commented Apr 4, 2015

Is it because media queries don't inherit from the :root element?

@MoOx
Copy link
Contributor

MoOx commented Apr 4, 2015 via email

@MoOx MoOx closed this as completed Apr 7, 2015
@WolfgangKluge
Copy link

OK, here is a workaround (not in @custom-media so far)
https://github.com/WolfgangKluge/postcss-media-variables

@MoOx
Copy link
Contributor

MoOx commented Sep 3, 2015

You should use postcss-custom-media instead to stay in the future of CSS.

@quantuminformation
Copy link

I'm so happy about this!

@joshistoast
Copy link

You should use postcss-custom-media instead to stay in the future of CSS.

It's 2021 now, and this plugin hasn't been updated in 4 years and doesn't support PostCSS 7 or newer. Has anyone found a workaround or just decided to downgrade to PostCSS 6?

@quantuminformation
Copy link

i feel old

@Spone
Copy link

Spone commented Oct 1, 2021

You should use postcss-custom-media instead to stay in the future of CSS.

It's 2021 now, and this plugin hasn't been updated in 4 years and doesn't support PostCSS 7 or newer. Has anyone found a workaround or just decided to downgrade to PostCSS 6?

v8.0.0 supports PostCSS 8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants