Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaking global addresses in downstream dep uniqid #16

Closed
jwalton opened this issue Mar 29, 2017 · 2 comments
Closed

Leaking global addresses in downstream dep uniqid #16

jwalton opened this issue Mar 29, 2017 · 2 comments

Comments

@jwalton
Copy link

jwalton commented Mar 29, 2017

The package macaddress has a global leak in v0.2.8. This appears to be fixed in their master, but they haven't pushed the fix for 9 months.

The package uniqid relies on macaddress, so I'd like to harass them into switching from macaddress to some other package, but they were made aware of this issue six months ago, and they still haven't done anything.

So, I come to you. :) postcss-filter-plugins is a dependency of cssnano, which is a dependency of css-loader, which means quite a few webpack based projects get postcss-filter-plugins as an indirect dependency, and all of those projects will have mysterious test failures if they pass --check-leaks to mocha, so it would be nice to get this fixed. :) Can we replace uniqid with another library easily?

@jwalton
Copy link
Author

jwalton commented Mar 29, 2017

#15 would fix it perfectly, BTW.

@RyanZim
Copy link
Collaborator

RyanZim commented May 18, 2018

Fixed in #19.

@RyanZim RyanZim closed this as completed May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants