Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json should include engines property to note dependency on node 12 #82

Closed
ghost opened this issue Sep 15, 2015 · 3 comments
Closed

Comments

@ghost
Copy link

ghost commented Sep 15, 2015

I was currently on node 10 and trying to use the latest version, which doesn't work due to no native Promise support. The package.json should note that node 12 is a dependency via the engines property so npm installs on node 10 will throw a warning.

@TrySound
Copy link
Member

@lambertsteven You can always polyfill promises with es6-promise. I wouldn't like to get the warning everytime I install this on old machine.

@ghost
Copy link
Author

ghost commented Sep 15, 2015

I can understand that. Could we get a note on the readme at the least that postcss-import depends on native Promises and either that requires node 12 or es6-promises?

@TrySound
Copy link
Member

@lambertsteven It make sense for postcss readme, cause postcss-import and all postcss plugins depends on it.
But https://github.com/postcss/postcss#usage

@ghost ghost closed this as completed Sep 16, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant