Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(index): add CSS Modules support (postcss-modules) #323

Closed
wants to merge 1 commit into from

Conversation

michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Dec 13, 2017

⚠️ DO NOT MERGE ⚠️

This PR is for testing purposes only and will never land in postcss-loader this way, it's goal is to publicly test, polish and gather feedback for the remaining TODO's to make CSS Modules work with postcss-loader && css-loader v1.0.0

Code in lib/modules maps to each plugin in css-modules/postcss-icss-${filename} where it finally belongs 😛

Messages (Formats) (result.messages.modules (?))

values

ℹ️ Coming soon...

{
   ...
}

selectors

{
   `{selector}`: `${hash}` 
}

keyframes

ℹ️ Coming soon...

{
   ...
}

composes

ℹ️ Coming soon...

{
   ...
}

Type


  • Feature

SemVer


  • Feature (:label: Minor)

Issues


Checklist


  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@michael-ciniawsky michael-ciniawsky changed the title feat(index): add CSS Modules support (postcss-modules) [WIP] feat(index): add CSS Modules support (postcss-modules) Dec 13, 2017
@coveralls
Copy link

coveralls commented Dec 13, 2017

Coverage Status

Coverage decreased (-0.3%) to 86.335% when pulling 1d6929a on feature/modules into 6022083 on feature/meta.

@michael-ciniawsky michael-ciniawsky changed the title [WIP] feat(index): add CSS Modules support (postcss-modules) feat(index): add CSS Modules support (postcss-modules) Feb 2, 2018
@michael-ciniawsky michael-ciniawsky deleted the feature/modules branch February 2, 2018 02:45
@alexander-akait
Copy link
Member

@michael-ciniawsky why close?

@michael-ciniawsky
Copy link
Member Author

I working on upstreaming the first bits to the appropiate plugins, this PR was never intented to land in postcss-loader. I opened it for discussion and visibility for others. I have the css-webpack-plugin && css-loader && style-loader ready for polishing, but there are a few things to discuss and I will summarize them in a gist instead when the code for each package is ready for alpha testing, so it's hopefully easier to finish the remaining TODO's and find consensus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants