Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index): remove sourceMap warning #361

Merged
merged 3 commits into from May 4, 2018

Conversation

yyx990803
Copy link
Contributor

@yyx990803 yyx990803 commented May 4, 2018

ℹ️ Describe the big picture of your changes here to communicate to the maintainers
why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.

Currently as long as there is a source map passed from an upstream loader (e.g. vue-loader), postcss-loader warns about sourceMap being discarded even when the sourceMap option is explicitly set to false. It should only warn when the option is "not set".

Type


ℹ️ What types of changes does your code introduce?

Put an x in the boxes that apply

  • Fix
  • Perf
  • Docs
  • Test
  • Chore
  • Feature
  • Refactor

SemVer


ℹ️ What changes to the current semver range does your PR introduce?

Put an x in the boxes that apply

  • Bug (:label: Patch)
  • Feature (:label: Minor)
  • Breaking Change (:label: Major)

Issues


ℹ️ What issue (if any) are closed by your PR?

Replace #1 with the error number that applies

N/A

Checklist


ℹ️ You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is a reminder of what we are going to look for before merging your code.

Put an x in the boxes that apply.

  • Lint and unit tests pass with my changes
  • I have added tests that prove my fix is effective/works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes are merged and published in downstream modules

@coveralls
Copy link

coveralls commented May 4, 2018

Coverage Status

Coverage increased (+0.9%) to 90.196% when pulling 2bb855c on yyx990803:patch-1 into 2484275 on postcss:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 89.375% when pulling 367f180 on yyx990803:patch-1 into 2484275 on postcss:master.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this warning altogether, it was added in good faith but folks use this loader in all various ways where an intermediated source map may be required for whatever reason... Please remove the notice from the docs aswell then https://github.com/postcss/postcss-loader#sourcemap (the blockquote starting with ⚠️ and following)

@michael-ciniawsky michael-ciniawsky added this to the 2.1.3 milestone May 4, 2018
@michael-ciniawsky michael-ciniawsky changed the title fix(index): do not emit sourceMap warning when explicitly set to false fix(index): remove sourceMap warning May 4, 2018
@yyx990803
Copy link
Contributor Author

Done.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented May 4, 2018

Released in v2.1.5 🎉

@yoyo837
Copy link

yoyo837 commented May 8, 2018

Released in v2.0.5 v2.1.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants