Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about downsampling factor #7

Closed
Len-Li opened this issue Dec 20, 2021 · 2 comments
Closed

Question about downsampling factor #7

Len-Li opened this issue Dec 20, 2021 · 2 comments
Labels
question Further information is requested

Comments

@Len-Li
Copy link

Len-Li commented Dec 20, 2021

Hi,
Thanks for sharing your work!

I am confused about the downsampling factor in the LLFF dataset. In your config file, downsample factor is set to 8. However, in the original nerf repo, downsample factor is set to 4 according to this. I am curious that why do not follow the original setting. This may be unfair for comparision.

@jeongyw12382
Copy link
Collaborator

For the case of NeRF, our implementation is based on the PyTorch-NeRF, which is publicly available on https://github.com/yenchenlin/nerf-pytorch/blob/master/configs/fern.txt. If you visit the aforementioned link, the factor value is set to 8. We have followed the setup introduced in the repository to minimize code or setup modification that is already verified.

Thus, we re-evaluate the baseline model with our code for a fair comparison.

In addition, based on my experiments in the very early stage of the research, we have not observed large difference using factor 4 and factor 8. However, I have not verified whether there is a large gap between the two factor setups in the final model.

I hope this description might help you.

@jeongyw12382
Copy link
Collaborator

Closing the issue. Please reopen the issue whenever you have trouble using the repository.

@jeongyw12382 jeongyw12382 added the question Further information is requested label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants