Request 3.3.6 release

[heliosyne]

Can a new release on 3.3.x be made to cover the changes since 3.3.5? Things seem to have calmed down, and it would be nice to have a version tag now that the branch has stabilized.

[DavidGoodwin]

https://github.com/postfixadmin/postfixadmin/releases/tag/postfixadmin-3.3.6

[heliosyne]

Thanks!

[paulchen]

I'm afraid that something went wrong with that release.

It is based on revision 4d50521 where setup.php calls a function named db_connection_string():

postfixadmin/public/setup.php

Line 688 in 4d50521

$dsn = db_connection_string();

However, that function is not present anywhere in that revision. In master, it can be found in functions.inc.php: https://github.com/postfixadmin/postfixadmin/blob/master/functions.inc.php#L1563-L1601

In revision 4d50521, functions.inc.php does not contain that method yet: https://github.com/postfixadmin/postfixadmin/blob/4d505211efa785242bc69b7e6f7ffea9cf3d32da/functions.inc.php

[DavidGoodwin]

Thanks @paulchen .... 8ebb985 is missing.

psalm is meant to notice this sort of thing ... clearly I've messed up in relying on it, or not configured it correctly.

[DavidGoodwin]

https://github.com/postfixadmin/postfixadmin/releases/tag/postfixadmin-3.3.7

[paulchen]

@DavidGoodwin Thanks for the quick response, 3.3.7 looks better :)